Page MenuHomePhabricator

Language conversion-like syntax is highlighted and linted when language conversion is disabled
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enable Improved Syntax Highlighting beta feature (i.e., CodeMirror 6).
  • Edit the English Wikipedia sandbox page with syntax highlighting on.
  • Replace the content with -{x|}-.

What happens?:

The source text is highlighted as language conversion syntax, and an error is reported as invalid language conversion flag.

What should have happened instead?:

The source text should be highlighted as plain text, and no error should be found.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1227839 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorMediaWiki: skip unnecessary language conversion

https://gerrit.wikimedia.org/r/1227839

Change #1228170 had a related patch set uploaded (by Shivaansh Singh; author: Shivaansh Singh):

[mediawiki/extensions/CodeMirror@master] Fix: Don't highlight/lint language conversion syntax when conversion is disabled (T414857)

https://gerrit.wikimedia.org/r/1228170