Page MenuHomePhabricator

ImageRating incompatible with MediaWiki 1.45's new categorylinks schema
Open, Needs TriagePublicBUG REPORT

Description

First reported on https://issue-tracker.miraheze.org/T14459#296502

Steps to replicate the issue (include links if applicable):

  • Go to Special:ImageRating?type=best

What happens?:

[a2a161e29184ba3addaf8946] /wiki/Special:ImageRating?type=best Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading or after adding a new extension?

Please see https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Upgrading and https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:How_to_debug for more information.

Error 1054: Unknown column 'cl_to' in 'SELECT'
Function: ImageRating::execute
Query: SELECT cl_to,cl_sortkey,cl_from FROM `categorylinks` WHERE cl_from = 0

Backtrace:

from /srv/mediawiki/1.45/includes/libs/rdbms/database/Database.php(1225)
#0 /srv/mediawiki/1.45/includes/libs/rdbms/database/Database.php(1209): Wikimedia\Rdbms\Database->getQueryException(string, int, string, string)
#1 /srv/mediawiki/1.45/includes/libs/rdbms/database/Database.php(1183): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, int, string, string)
#2 /srv/mediawiki/1.45/includes/libs/rdbms/database/Database.php(640): Wikimedia\Rdbms\Database->reportQueryError(string, int, string, string, bool)
#3 /srv/mediawiki/1.45/includes/libs/rdbms/database/Database.php(1363): Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#4 /srv/mediawiki/1.45/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->select(string, array, array, string)
#5 /srv/mediawiki/1.45/includes/libs/rdbms/database/DBConnRef.php(384): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /srv/mediawiki/1.45/extensions/ImageRating/includes/specials/SpecialImageRating.php(439): Wikimedia\Rdbms\DBConnRef->select(string, array, array, string)
#7 /srv/mediawiki/1.45/includes/specialpage/SpecialPage.php(711): ImageRating->execute(null)
#8 /srv/mediawiki/1.45/includes/specialpage/SpecialPageFactory.php(1729): MediaWiki\SpecialPage\SpecialPage->run(null)
#9 /srv/mediawiki/1.45/includes/actions/ActionEntryPoint.php(499): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#10 /srv/mediawiki/1.45/includes/actions/ActionEntryPoint.php(143): MediaWiki\Actions\ActionEntryPoint->performRequest()
#11 /srv/mediawiki/1.45/includes/MediaWikiEntryPoint.php(184): MediaWiki\Actions\ActionEntryPoint->execute()
#12 /srv/mediawiki/config/initialise/entrypoints/index.php(71): MediaWiki\MediaWikiEntryPoint->run()
#13 {main}

What should have happened instead?:
Special page displayed normally.

Event Timeline

Restricted Application added a subscriber: Reception123. · View Herald Transcript

Per discussion at T412781: MediaWiki 1.45 incompatibility of BlogPage due to Categorylinks cl_to removal in 1.45, this is known but not a super high priority issue at the moment. Patches welcome, though! (As long as they retain MW 1.43 compatibility, per mw:Social tools/MediaWiki compatibility).

Thanks for the pointer. I guess we'll wait and see how things play out then. This schema migration will be pretty painful so I won't be able to do it in the short term either.