Page MenuHomePhabricator
Create Task
Maniphest T414875

Update JamesHeinrich/getID3 for php8.5 support
Closed, ResolvedPublic
Actions

Description

The current version of JamesHeinrich/getID3 in mediawiki/vendor is using the deprecated xml_parser_free (T410934)
Fix in https://github.com/JamesHeinrich/getID3/commit/c2343981165df70c4350dd747a4add0ace98cbcb (unreleased)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Require getid3 1.9.25 for php 8.5 compatiblityTheDJmediawiki/extensions/TimedMediaHandlermaster+1 -1
Require getid3 1.9.25 for php 8.5 compatiblityJforrestermediawiki/extensions/TimedMediaHandlerREL1_45+1 -1
Require getid3 1.9.25 for php 8.5 compatiblityJforrestermediawiki/extensions/TimedMediaHandlerREL1_44+1 -1
Require getid3 1.9.25 for php 8.5 compatiblityJforrestermediawiki/extensions/TimedMediaHandlerREL1_43+1 -1
Upgrading james-heinrich/getid3 (v1.9.24 => v1.9.25)Zabemediawiki/vendormaster+565 -282
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jan 18 2026, 12:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2026, 12:44 AM
Umherirrender moved this task from Backlog to Wikimedia production on the PHP 8.5 support board.Jan 18 2026, 12:44 AM
Umherirrender added a comment.Jan 18 2026, 1:11 AM

Also using imagedestroy (T413901), but plotting bmp files seems not used from this library

TheDJ moved this task from Backlog to Patch merged upstream on the Upstream board.Jan 18 2026, 10:07 AM
A_smart_kitten mentioned this in T227704: Codesearch: "mediawiki/vendor" is missing from Everything preset.Jan 18 2026, 6:56 PM
Umherirrender mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 20 2026, 8:38 PM
A_smart_kitten mentioned this in T413901: imagedestroy() is deprecated since PHP 8.5, as it has no effect since PHP 8.0.Jan 21 2026, 1:28 PM
Zabe subscribed.Jan 25 2026, 1:49 PM

https://github.com/JamesHeinrich/getID3/pull/484

Jdlrobson-WMF added a project: Reader Growth Team.Jan 26 2026, 5:09 PM
HSwan-WMF subscribed.Jan 29 2026, 6:02 PM

Shouldn't do until version is released.

HSwan-WMF triaged this task as Lowest priority.Jan 29 2026, 6:03 PM
HSwan-WMF raised the priority of this task from Lowest to Low.
Reedy moved this task from Patch merged upstream to Patch proposed upstream on the Upstream board.Jan 29 2026, 6:04 PM
Umherirrender unsubscribed.Jan 30 2026, 6:40 PM
A_smart_kitten moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.Feb 6 2026, 10:47 PM
A_smart_kitten subscribed.

https://github.com/JamesHeinrich/getID3/pull/484 has been merged upstream (but not yet released FWICS)

HSwan-WMF moved this task from Incoming/Inbox to Backlog on the Reader Growth Team board.Feb 10 2026, 9:14 PM
Jdforrester-WMF subscribed.Mar 4 2026, 9:13 PM

Note: This isn't triggering CI failures in vendor's or core's tests, so we're making PHP 8.5 voting in CI there, but presumably this needs doing once there's a newer release after v1.9.24 from last September?

gerritbot added a comment.Mar 10 2026, 11:49 PM

Change #1250118 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/vendor@master] Upgrading james-heinrich/getid3 (v1.9.24 => v1.9.25)

https://gerrit.wikimedia.org/r/1250118

gerritbot added a project: Patch-For-Review.Mar 10 2026, 11:49 PM
A_smart_kitten added a parent task: T413901: imagedestroy() is deprecated since PHP 8.5, as it has no effect since PHP 8.0.Mar 21 2026, 3:06 PM
gerritbot added a comment.Mar 22 2026, 4:29 PM

Change #1250118 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading james-heinrich/getid3 (v1.9.24 => v1.9.25)

https://gerrit.wikimedia.org/r/1250118

Zabe closed this task as Resolved.Mar 22 2026, 7:55 PM
Zabe claimed this task.
TheDJ mentioned this in T357035: webm issue: Some videos on Commons have no duration in their metadata.Mar 23 2026, 7:07 AM
TheDJ mentioned this in T414645: Midi files with duration 0 due to not having tempo events.Mar 31 2026, 11:08 AM
TheDJ mentioned this in T414641: Some flac files have duration 0.Mar 31 2026, 11:40 AM
gerritbot added a comment.Apr 4 2026, 12:14 PM

Change #1268060 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268060

gerritbot added a comment.Apr 4 2026, 12:29 PM

Change #1268060 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268060

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.23; 2026-04-07).Apr 4 2026, 1:00 PM
Jdlrobson-WMF removed a project: Reader Growth Team.Apr 7 2026, 11:49 PM
gerritbot added a comment.Apr 8 2026, 12:10 AM

Change #1268689 had a related patch set uploaded (by Jforrester; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_45] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268689

gerritbot added a comment.Apr 8 2026, 12:11 AM

Change #1268690 had a related patch set uploaded (by Jforrester; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_44] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268690

gerritbot added a comment.Apr 8 2026, 12:11 AM

Change #1268691 had a related patch set uploaded (by Jforrester; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_43] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268691

gerritbot added a comment.Apr 8 2026, 12:14 AM

Change #1268691 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_43] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268691

gerritbot added a comment.Apr 8 2026, 12:14 AM

Change #1268690 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_44] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268690

gerritbot added a comment.Apr 8 2026, 12:14 AM

Change #1268689 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_45] Require getid3 1.9.25 for php 8.5 compatiblity

https://gerrit.wikimedia.org/r/1268689

Reedy removed a project: Patch-For-Review.Apr 24 2026, 5:30 PM
TheDJ mentioned this in T403213: TimedMediaHandler: upstream getid3: PHP Warning: Undefined array key "TrackUID".Jun 14 2026, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits