Page MenuHomePhabricator

New Pages Feed Rollover
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • go to [[Special:NewPagesFeed]] on enwiki
  • scroll until the feed has to reload (20 articles/ api limit)
  • compare the first article that loads with one of the newest article in the feed

What happens?:
The NewPagesFeed rolls over and displays the first few articles again before displaying older ones.

What should have happened instead?:

It should continually show older articles without rolling over to show a few of the newest articles

Other information (browser name/version, screenshots, etc.):

See the timestamps of the articles (feed is sorted newest to oldest)

Screenshot 2026-01-18 at 20.27.37.png (1×436 px, 71 KB)

Event Timeline

Change #1228312 had a related patch set uploaded (by Prashant_32194; author: Prashant_32194):

[mediawiki/extensions/PageTriage@master] Fix NewPagesFeed pagination rollover

https://gerrit.wikimedia.org/r/1228312

Change #1228449 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Use page creation date as offset only if the legacy ordering is specified

https://gerrit.wikimedia.org/r/1228449

Change #1228312 abandoned by Prashant_32194:

[mediawiki/extensions/PageTriage@master] Fix NewPagesFeed pagination rollover

https://gerrit.wikimedia.org/r/1228312

Novem_Linguae subscribed.

I was able to reproduce on enwiki. The 2nd, 3rd, 4th etc. chunks are identical.

Judging by the fix in Soda's patch, is probably a Regression related to T412014

Looks kind of hard to test the patch in localhost. Would either need to generate a lot of unreviewed articles, or temporarily reduce the size of the API query.

This ticket should probably be a high-ish priority. It hides a lot of the feed. We should probably backport the fix once the patch is merged.

Seems like this bug is present in NPP Newest, AFC Submitted Date Newest, and AFC Submitted Date Oldest, but not NPP Oldest.

Change #1228449 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Use page creation date as offset only if the legacy ordering is specified

https://gerrit.wikimedia.org/r/1228449

jsn.sherman changed the task status from Open to In Progress.Tue, Jan 20, 5:51 PM
jsn.sherman moved this task from Ready to QA on the Moderator-Tools-Team (Kanban) board.

Change #1229172 had a related patch set uploaded (by Jsn.sherman; author: Sohom Datta):

[mediawiki/extensions/PageTriage@wmf/1.46.0-wmf.12] Use page creation date as offset only if the legacy ordering is specified

https://gerrit.wikimedia.org/r/1229172

I wasn't able to reproduce this issue beta wiki, but I did verify that the patch doesn't break things; it seems to do the job locally, so I'm going to backport this during tomorrow's UTC afternoon backport window:
https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20260121T1400

I made a little user script to check for duplicate pages:
https://en.wikipedia.org/wiki/User:JSherman_(WMF)/T414892.js
It adds a toolbox link that scrolls the page until there are no more entries, checks for duplicate titles, and lists them in an alert. Nothing fancy, but this should make testing much quicker during deploy since I won't have to catch new duplicates by eye.

Change #1229172 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.46.0-wmf.12] Use page creation date as offset only if the legacy ordering is specified

https://gerrit.wikimedia.org/r/1229172

Mentioned in SAL (#wikimedia-operations) [2026-01-21T14:13:57Z] <jsn@deploy2002> Started scap sync-world: Backport for [[gerrit:1229172|Use page creation date as offset only if the legacy ordering is specified (T414892)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-21T14:16:11Z] <jsn@deploy2002> jsn: Backport for [[gerrit:1229172|Use page creation date as offset only if the legacy ordering is specified (T414892)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-21T14:31:22Z] <jsn@deploy2002> Finished scap sync-world: Backport for [[gerrit:1229172|Use page creation date as offset only if the legacy ordering is specified (T414892)]] (duration: 17m 24s)

Backported to test wiki and looking good there:

Screenshot From 2026-01-21 08-34-40.png (1×1 px, 392 KB)

(I realize now I failed to grab a screenshot of me reproducing the issue on testwiki, but it was intermittently reproducible there)

You should see this on enwiki when 1.46.0-wmf.12 rolls to group 2

Bad news; I realized that my testing on test was not going far enough back; I amended my script to allow multiple runs that add on to the already loaded list (instead of repeatedly starting from scratch) and I'm now able to consistently get duplicates on testwiki, which has the patch

{F71584628}

For what it's worth, the patch seems to have mitigated/reduced some cause of duplicates when loading fewer pages from the list, but there is still another underlying problem to address.

To reproduce, log into test wiki and load my script from your common.js; mine looks like this:

// see https://phabricator.wikimedia.org/T414892
mw.loader.getScript( 'https://en.wikipedia.org/wiki/User:JSherman_(WMF)/T414892.js?action=raw&ctype=text/javascript&date=2026-01-21.1' );

note that I added a date param to bust cache as I update the test script.

hmm; I rechecked on the debug host on a whim. I'm still seeing 0 duplicates on the debug testwiki host.

I verified that testwiki does show the right commit for PageTriage with and without the debug host:
https://test.wikipedia.org/wiki/Special:Version#mw-version-ext-specialpage-PageTriage

Now that I'm that I'm looking for this in the requests, I can see that my script is missing some duplicates; I'll see if I can correct that

I did 3 runs of my script (~ 9 minutes of scrolling the feed) now that enwiki is on 1.46.0-wmf.12 and found 0 duplicates! You can see the filter settings in the first screenshot below. I'll leave this open for now to see how it's looking for the NPP folks.

Screenshot 2026-01-22 at 08-36-46 New pages feed - Wikipedia.png (1×1 px, 274 KB)

Screenshot From 2026-01-22 08-40-25.png (1×1 px, 281 KB)

Unable to reproduce. Looks fixed now. I'd be OK with closing the ticket. Thanks to Sohom and Jason for fixing this.

jsn.sherman claimed this task.

Okay, I closed it out; if somebody else runs across a case that we missed, please do reopen!

jsn.sherman updated Other Assignee, added: jsn.sherman.

Change #1235851 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Revert "Use page creation date as offset only if the legacy ordering is specified"

https://gerrit.wikimedia.org/r/1235851

Change #1235851 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Revert "Use page creation date as offset only if the legacy ordering is specified"

https://gerrit.wikimedia.org/r/1235851