Why not use preg_quote() to mitigate this?

In T414901#11532301, @Redmin wrote:

Why not use preg_quote() to mitigate this?

Yes, that should be sufficient:

> php -r "echo preg_quote('(a+)+');"
> \(a\+\)\+

Tagging a couple of the most recent project maintainers...

Like this?

diff --git a/src/EventSubscriber/RateLimitSubscriber.php b/src/EventSubscriber/RateLimitSubscriber.php
index 64b6bd28..31951c14 100644
--- a/src/EventSubscriber/RateLimitSubscriber.php
+++ b/src/EventSubscriber/RateLimitSubscriber.php
@@ -172,7 +172,7 @@ class RateLimitSubscriber implements EventSubscriberInterface {
 
                // If requesting the same language as the target project, ignore.
                // FIXME: This has side-effects (T384711#10759078)
-               if ( preg_match( "/[=\/]$useLang.?wik/", $this->uri ) === 1 ) {
+               if ( preg_match( '/[=\/]' . preg_quote( $useLang ) . '?wik/', $this->uri ) === 1 ) {
                        return;
                }

Adding another XTools maintainer.

Does not seem to be a Cloud-VPS infrastructure issue, thus untagging us.

In T414901#11540046, @Samwilson wrote:

Like this?
...

Yep, that's sufficient.

The best path forward here is to probably create a public pull request for the xtools repo and then quickly merge and deploy it to the cloud project.

Done:

https://github.com/x-tools/xtools/pull/615
https://github.com/x-tools/xtools/pull/616

And I've released version 3.24.1 with the change. That will be auto deployed within ten minutes.

In T414901#11543697, @Samwilson wrote:

Done:

https://github.com/x-tools/xtools/pull/615
https://github.com/x-tools/xtools/pull/616

And I've released version 3.24.1 with the change. That will be auto deployed within ten minutes.

Thanks! I'd like to resolve this task and make it public now unless you have any other concerns.

Yep fine by me. Unless @Redmin wants to double-check first?

Nah, thanks for patching this; it looks good.