Page MenuHomePhabricator

Update CheckUserTemporaryAccountsByIPLookup service to return a list of connected temporary account names
Open, Needs TriagePublic

Description

Background

As part of making it easier to see connected temporary accounts who are sharing the same IP address, we would like to show contributions and logs for multiple temporary accounts.

This will require being able to look up which temporary accounts are related to a given temporary account.

What to do

We already have the ability via CheckUserTemporaryAccountsByIPLookup to find a count of all related temporary accounts which takes a temporary account, finds all the IPs it has used, and finds all the temporary accounts that have used any of those IPs. We should build on this to return the actual names of the temporary accounts.

Acceptance criteria
  • There is a public method for looking up names of related temp accounts
  • It is only usable by users who have IP reveal rights
  • It hides hidden user names if the performer does not have the right to see them

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1228503 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookupTest: Use correct IP for creations

https://gerrit.wikimedia.org/r/1228503

Change #1228504 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Add method for getting related account names

https://gerrit.wikimedia.org/r/1228504

Change #1228503 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookupTest: Use correct IP for creations

https://gerrit.wikimedia.org/r/1228503

Change #1229148 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Log when related temporary accounts are looked up

https://gerrit.wikimedia.org/r/1229148

Moving to review since there are patches to review, but we're awaiting an answer from Legal about whether access to related temporary accounts needs to be logged, before all the code can be merged.

Change #1228504 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add method for getting related temporary account names

https://gerrit.wikimedia.org/r/1228504

Change #1233731 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookupTest: Fix flaky test

https://gerrit.wikimedia.org/r/1233731

Change #1233731 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookupTest: Fix flaky test

https://gerrit.wikimedia.org/r/1233731

Moving to review since there are patches to review, but we're awaiting an answer from Legal about whether access to related temporary accounts needs to be logged, before all the code can be merged.

Legal did approve the log.

Change #1234284 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookup: Prepare queries for paging

https://gerrit.wikimedia.org/r/1234284

Change #1234285 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookup: Support offset in lookup

https://gerrit.wikimedia.org/r/1234285

Change #1229148 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Log when related temporary accounts are looked up

https://gerrit.wikimedia.org/r/1229148

Change #1234284 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUserTemporaryAccountsByIPLookup: Prepare queries for paging

https://gerrit.wikimedia.org/r/1234284