Page MenuHomePhabricator

resolve “jobs-framework” and “web” image variants to the same image
Closed, DuplicatePublic

Description

When reading jobs from k8s or submitting jobs, we want to resolve any image variant whether job-framework or web to whatever image variant we want to support in jobs-api.

for example right now we only want to support jobs-framework images, so we want to resolve images like docker-registry.svc.toolforge.org/toolforge-python313-sssd-web to docker-registry.svc.toolforge.org/toolforge-python313-sssd-base.

in the future when we switch to supporting only web images, we want to resolve images like `docker-registry.svc.toolforge.org/toolforge-python313-sssd-base to `docker-registry.svc.toolforge.org/toolforge-python313-sssd-web

Event Timeline

raymond-ndibe updated https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/260

Draft: images::from_url_or_name: match variants of the same image

Raymond_Ndibe changed the task status from Open to In Progress.Jan 19 2026, 3:48 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1113

jobs-api: test for proper handling of the diff variations of the --image argument

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1115

jobs-api: test for proper handling of the diff variations of the --image argument

fnegri changed the task status from Declined to Resolved.Feb 3 2026, 3:10 PM
fnegri moved this task from In Review to Done on the Toolforge (Toolforge iteration 25) board.

As far as I can see, this task has no merged changes attached, but instead there is an open patch. How exactly is this resolved?

JJMC89 changed the task status from Resolved to Declined.Feb 3 2026, 3:36 PM

@taavi sorry I involuntarily resolved this by dragging it in the Toolforge board that has an action attached to columns. :/

My previous question remains: @Raymond_Ndibe why was this closed as declined? The patch https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1115 is still open.

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1134

jobs-api: test for proper handling of the diff variations of the --image argument

@taavi sorry I involuntarily resolved this by dragging it in the Toolforge board that has an action attached to columns. :/

My previous question remains: @Raymond_Ndibe why was this closed as declined? The patch https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1115 is still open.

I decided to assign the open MRs about this issue to the task https://phabricator.wikimedia.org/T415322, they are more or less the same thing, so I wanted to reduce clutter

I decided to assign the open MRs about this issue to the task https://phabricator.wikimedia.org/T415322, they are more or less the same thing, so I wanted to reduce clutter

Ok, makes sense! There's also https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1113 that is still pointing to this task.

I decided to assign the open MRs about this issue to the task https://phabricator.wikimedia.org/T415322, they are more or less the same thing, so I wanted to reduce clutter

Ok, makes sense! There's also https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1113 that is still pointing to this task.

yes that is correct. I should update that