Page MenuHomePhabricator
Create Task
Maniphest T414981

EmailAuthHooksTest tests fail in CheckUser repo
Closed, ResolvedPublic
Actions

Description

The WikimediaEvents\Tests\Unit\EmailAuthHooksTest::testShouldRequireVerificationForNon2FAUsersOnUnknownIPsKnownToIpoid test is failing in the CheckUser gate-and-submit CI pipeline:

15:42:36 1) WikimediaEvents\Tests\Unit\EmailAuthHooksTest::testShouldRequireVerificationForNon2FAUsersOnUnknownIPsKnownToIpoid with data set "2FA disabled, email not confirmed, known to ipoid, not bot user, $wgWikimediaEventsEmailAuthEnforce: false, LoginNotify status: LoginNotify::USER_NOT_KNOWN, last activity unknown" (false, false, true, false, false, 'LoginNotify::USER_NOT_KNOWN', null)
15:42:36 PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "MediaWiki\Extension\IPReputation\IPoidResponse" does not exist
15:42:36 
15:42:36 /workspace/src/extensions/WikimediaEvents/tests/phpunit/EmailAuthHooksTest.php:202

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
EmailAuthHooksTest: Fix namespace of IPoidResponseKosta Harlanmediawiki/extensions/WikimediaEventsmaster+1 -1
tests: Fix IPoidResponse namespace import in EmailAuthHooksTestAarohisharma3mediawiki/extensions/WikimediaEventsmaster+1 -1
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Jan 19 2026, 3:48 PM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptJan 19 2026, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dreamy_Jazz edited projects, added: Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)); removed: Product Safety and Integrity.Jan 19 2026, 3:49 PM
kostajh claimed this task.Jan 19 2026, 4:32 PM
gerritbot added a comment.Jan 19 2026, 4:33 PM

Change #1228546 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikimediaEvents@master] EmailAuthHooksTest: Fix namespace of IPoidResponse

https://gerrit.wikimedia.org/r/1228546

gerritbot added a project: Patch-For-Review.Jan 19 2026, 4:33 PM
Dreamy_Jazz closed this task as Resolved.Jan 19 2026, 4:36 PM
Dreamy_Jazz moved this task from Backlog to Done on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.

+2 given to the patch

gerritbot added a comment.Jan 19 2026, 4:44 PM

Change #1228551 had a related patch set uploaded (by Aarohisharma3; author: Aarohisharma3):

[mediawiki/extensions/WikimediaEvents@master] tests: Fix IPoidResponse namespace import in EmailAuthHooksTest

https://gerrit.wikimedia.org/r/1228551

gerritbot added a comment.Jan 19 2026, 4:45 PM

Change #1228546 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] EmailAuthHooksTest: Fix namespace of IPoidResponse

https://gerrit.wikimedia.org/r/1228546

gerritbot added a comment.Jan 19 2026, 4:45 PM

Change #1228551 abandoned by Dreamy Jazz:

[mediawiki/extensions/WikimediaEvents@master] tests: Fix IPoidResponse namespace import in EmailAuthHooksTest

Reason:

Hi. This patch already exists at Ib94eb7474ed3cacdfe8acb046ad8a310ef7d9574 which is already being merged, thanks for this though

https://gerrit.wikimedia.org/r/1228551

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2026, 5:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits