Page MenuHomePhabricator

Vector TOC in Sticky header is styled incorrectly and empty when changing viewports
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Log into Vector
  • Visit https://en.wikipedia.org/wiki/Initial_campaign_of_the_Breton_Civil_War on a large screen with the table of contents in the left sidebar by default (refresh page after correcting if not present)
  • Scroll down to show the sticky header
  • Move the TOC to the sticky header by pressing the "hide" button in the TOC
  • Note: the incorrect spacing:
    Screenshot 2026-01-23 at 12.22.16 PM.png (96×84 px, 4 KB)
  • Decrease the viewport so that the sticky header disappears
  • Increase the viewport so the sticky header is back
  • Click the TOC button to see the TOC doesnt work

What happens?:

Screenshot 2026-01-19 at 2.04.04 PM.png (148×310 px, 14 KB)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
In production on english wiki

Other information (browser name/version, screenshots, etc.):

Event Timeline

bwang triaged this task as High priority.Jan 19 2026, 7:13 PM

Change #1229147 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix sticky header toc spacing

https://gerrit.wikimedia.org/r/1229147

Change #1229147 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix sticky header TOC spacing and TOC disappearing on viewport change

https://gerrit.wikimedia.org/r/1229147

Sneha lowered the priority of this task from High to Medium.Jan 27 2026, 6:29 PM

Checked on cawiki wmf.13 and hewiki wmf.13 - the fix for the spacing is in place.

Screenshot 2026-01-28 at 6.28.00 PM.png (210×1 px, 56 KB)
Screenshot 2026-01-28 at 6.31.23 PM.png (156×842 px, 22 KB)

The second issue - the empty TOC after changing the width of the viewport is not reproducible on on wmf.13.
Waiting for enwiki wmf.13 to confirm that the original issue is fixed.

Jdlrobson-WMF set the point value for this task to 3.Feb 2 2026, 4:55 PM

Per async estimation.

Change #1235845 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix sticky header TOC spacing and TOC disappearing on viewport change

https://gerrit.wikimedia.org/r/1235845

Change #1235845 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix sticky header TOC spacing and TOC disappearing on viewport change

https://gerrit.wikimedia.org/r/1235845

I wasn't fast enough to comment on Gerrit before the patch was approved. The new patch causes a regression in T349436: Kerns are clipped from sides of sticky header title.

The overhang on the right side of italic f is clipped (only left side is still correct):

image.png (50×1 px, 6 KB)

Long page titles now overlap the rest of the sticky header:

image.png (50×1 px, 12 KB)

Compare to the desired rendering in my screenshots at T349436#11482237.

Change #1236781 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix sticky header TOC spacing and overflow

https://gerrit.wikimedia.org/r/1236781

Change #1236781 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix sticky header TOC spacing and overflow

https://gerrit.wikimedia.org/r/1236781