Page MenuHomePhabricator

Tables with empty cells render incorrectly in Parsoid
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Empty cell of the table doesn't render correctly in view mode. Empty cache or doing a null edit doesn't change this.

Parser seems to work fine in Preview mode though.

What should have happened instead?:
Empty cell should be rendered as an empty cell

Other information (browser name/version, screenshots, etc.):
This started happening today or very close to today. The issue didn't occur a few days ago.

image.png (1×1 px, 439 KB)

Event Timeline

Huji triaged this task as Unbreak Now! priority.Tue, Jan 20, 12:15 AM

Per wikitech documentation as this is a major loss of UI elements.

Not able to identify the root cause yet, but it seems to have to do with Template:Void or other empty pages being transcluded in the table.

Great catch. Updating project tags accordingly.

For additional context, the empty table cell is supposed to be created by transcluding an empty page such as this one but it seems like Parsoid sees the table cell seperators (the || before and the || after) and *nothing* in between, so sticks them together.

ssastry lowered the priority of this task from Unbreak Now! to High.Tue, Jan 20, 12:35 AM
ssastry edited projects, added Content-Transform-Team; removed MediaWiki-Parser.
ssastry subscribed.

This is a bug and we will fix it, but unless this is having a largescale impact, this is not an UBN.

cscott renamed this task from Tables with empty cells render incorrectly to Tables with empty cells render incorrectly in Parsoid.Tue, Jan 20, 7:43 PM

Change #1229658 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TableFixups: Fix regexp preventing cell splitting for empty cells

https://gerrit.wikimedia.org/r/1229658

Change #1229658 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Fix regexp preventing cell splitting for empty cells

https://gerrit.wikimedia.org/r/1229658

Change #1233217 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a13

https://gerrit.wikimedia.org/r/1233217

Change #1233217 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a13

https://gerrit.wikimedia.org/r/1233217