Page MenuHomePhabricator

Codex-PHP: Table sorting buttons overlap cells
Closed, ResolvedPublicBUG REPORT

Description

The table sorting buttons in Codex-PHP overlap the neighbouring header cells, e.g.:

image.png (276×972 px, 21 KB)

There is no example of sorting in the CSS-only version docs.


Derived Requirement

Ensure that table sorting buttons in Codex-PHP tables are laid out without overlapping adjacent header cells, so column headers remain fully visible and readable when sorting is available.

Test Steps

Test Case 1: Ensure sorting buttons do not overlap neighboring header cells

  1. Navigate to a Codex-PHP documentation page that includes a sortable table.
  2. Locate the table header row containing sorting buttons.
  3. Observe the layout of each sortable column header.
  4. ✅❓❌⬜ AC1: Sorting buttons do not overlap adjacent header cells, and all column header text remains fully visible.

Test Case 2: Ensure header layout remains stable when interacting with sorting buttons

  1. In a Codex-PHP sortable table, click a column’s sorting button.
  2. Observe the header row layout before and after sorting is applied.
  3. ✅❓❌⬜ AC2: Interacting with sorting buttons does not cause header cells to overlap or shift in a way that obscures neighboring headers.

QA Results -Beta

ACStatusDetails
1T415016#11593223
2T415016#11593223

Details

Other Assignee
GMikesell-WMF
Related Changes in Gerrit:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1229216 had a related patch set uploaded (by Samwilson; author: Samwilson):

[design/codex-php@main] Add missing button structure to table sorting buttons

https://gerrit.wikimedia.org/r/1229216

Change #1229216 merged by jenkins-bot:

[design/codex-php@main] Add missing button structure to table sorting buttons

https://gerrit.wikimedia.org/r/1229216

@Samwilson Please review AC1, thanks!

Test Result - Beta

Status: ✅ PASS ❌ FAIL
Environment: Beta
OS: macOS Tahoe 26.2
Browser: Chrome 143
Device: MBA
Emulated Device: NA

Test Artifact(s): Screenshots of Codex-PHP tables with sortable headers

Test Steps

Test Case 1: Ensure sorting buttons do not overlap neighboring header cells

  1. Navigate to a Codex-PHP documentation page that includes a sortable table.
  2. Locate the table header row containing sorting buttons.
  3. Observe the layout of each sortable column header.
  4. AC1: Sorting buttons do not overlap adjacent header cells, and all column header text remains fully visible.

Name crosses over Items

Test Case 2: Ensure header layout remains stable when interacting with sorting buttons

  1. In a Codex-PHP sortable table, click a column’s sorting button.
  2. Observe the header row layout before and after sorting is applied.
  3. ✅❓❌⬜ AC2: Interacting with sorting buttons does not cause header cells to overlap or shift in a way that obscures neighboring headers.

See AC1

GMikesell-WMF changed the task status from Open to In Progress.Fri, Feb 6, 10:44 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Fox Squad) board.

Oh yep, sorry! I totally forgot that there's an extra step here: the changes to Codex-PHP have to be released and updated in MediaWiki core. So there's nowhere to tests. Sorry to waste your time!

I guess we could stall this task pending the resolution of T409498 (or at least T382414), but I think it's fine to just resolve it now, and if there are still issues once the new version of Codex-PHP is out we can open new tasks then.