Page MenuHomePhabricator
Create Task
Maniphest T415065

🦠Merge all of the JavaScript Dependabot updates for Platform UI
Open, Needs TriagePublic
Actions

Description

Look at all of the open PRs in: https://github.com/wbstack/ui/pulls?q=is%3Apr+is%3Aopen+label%3Ajavascript

Each of these should be merged in turn. After all the changes have been successfully merged we'll deploy the latest image to staging, check it works and then deploy to production.

Once they are all merged check the wbaas-deploy repo. Close all but the most recent ui wmdebot automatic image updating PRs.

Ship this new image to staging. Check staging works and there isn't a spike in errors.

Ship this new image to production. Check this also works and there's no spike in errors.

Late Addition: Anything that can't me merged due to failing checks or complex additional dependencies we should open a ticket in the Engineering Backlog for and skip. If you see an easy, quick way to solve it go ahead and use your judgement though.

Event Timeline

Ollie.Shotton_WMDE created this task.Tue, Jan 20, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jan 20, 1:34 PM
Ollie.Shotton_WMDE renamed this task from Merge all of the GitHub Actions javascript Dependabot updates for Platform UI to Merge all of the JavaScript Dependabot updates for Platform UI.Tue, Jan 20, 1:39 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE moved this task from Engineering MicroTasks to Kanban Board on the Wikibase Cloud board.Tue, Jan 20, 1:42 PM
Ollie.Shotton_WMDE edited projects, added Wikibase Cloud (Kanban Board); removed Wikibase Cloud.
Rosalie_WMDE moved this task from To do to Doing on the Wikibase Cloud (Kanban Board) board.Thu, Jan 22, 2:10 PM
Rosalie_WMDE claimed this task.Thu, Jan 22, 2:17 PM
Tarrow updated the task description. (Show Details)Mon, Jan 26, 9:36 AM
Rosalie_WMDE added a comment.EditedMon, Jan 26, 3:55 PM

All open green JS PRs from dependabot have been closed including the ones that needed git conflicts to be resolved. currently all the PRs left are red and failing due to a dependency conflicts.

For example while looking at https://github.com/wbstack/ui/pull/869 you will notice that it fails here https://github.com/wbstack/ui/actions/runs/21281834718/job/61253436697?pr=869 because we use @vue/cli-plugin-unit-jest@5.0.8 and Vue CLI5 does not support @vue/vue2-jest@29.2.6. So if we want to upgrade jest 27 to 29 we will need to drop Vue CLI. I think dropping/replacing packages we use is out of scope of this task.

The other PRs have very similar issues.

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Mon, Jan 26, 3:56 PM
Rosalie_WMDE subscribed.
Rosalie_WMDE moved this task from Doing to Tech Breakdown on the Wikibase Cloud (Kanban Board) board.Mon, Jan 26, 4:12 PM
Tarrow moved this task from Tech Breakdown to To do on the Wikibase Cloud (Kanban Board) board.Thu, Feb 5, 9:54 AM
Tarrow subscribed.

We talked about this in the seniors round:

  • this is probably ready to pick up again
  • the remaining work to do is making the tickets in the engineering backlog to address the hard to merge PRs
  • the default assumption should be one PR per dependency that can't be updated but feel free to consolidate (merge together) dependencies that are coupled together.
Tarrow renamed this task from Merge all of the JavaScript Dependabot updates for Platform UI to 🦠Merge all of the JavaScript Dependabot updates for Platform UI.Thu, Feb 5, 9:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits