Page MenuHomePhabricator

Apply proper permission checks for meeting and chat URLs in GET event endpoint
Open, Needs TriagePublic

Description

In T410560, the meeting and chat URLs have been removed from the "GET event" endpoint because we weren't applying proper permission checks to them. Now that the immediate leak has been addressed, this task tracks the follow-up work of restoring those fields in the response with proper permission checks.

Acceptance criteria

  • Meeting and chat URL in the "GET event" endpoint response should be subject to the same permission checks as the UI (user must not be blocked and either organizer or participant; and the event should be on the current wiki):
    • When there is no URL, the value shall always be null regardless of permissions
    • When there is an URL, the field shall be set in the response iff the user has the necessary permissions
  • The endpoint documentation should be updated.

Event Timeline

Change #1225026 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Rest: Apply permission checks to meeting and chat URL in GET event

https://gerrit.wikimedia.org/r/1225026

Change #1225026 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Rest: Apply permission checks to meeting and chat URL in GET event

https://gerrit.wikimedia.org/r/1225026