🐛🚨 Membership moderation is broken
Open, Needs TriagePublic1 Estimated Story Points
Actions

Description

in the Fundraising backend (FOC / https://backend.wikimedia.de/):

Problem:
A user wants to moderate memberships on the Mitglieder tab.
They want to "unmoderate" a specific membership (74245).

Expected behaviour:

The membership is changing its state to unmoderated and shows it in the frontend.
the detail view can be opened

Actual behaviour:

> When we click on "Freigeben" the screen flickers for a sec but nothing else seems to be happening.
the detail view for each membership can't be opened

Our HTTP endpoint /member/unlock returns a status 500 on the request.

For donations it seems to work.
Our last deployment to prod+test was on 2025-12-02T15-07-28Z.
Priority:

unmoderate the affected membership manually

Helpful links / Notes:

https://github.com/wmde/fundraising-backend/blob/main/doc/Backup_Personal_Data.md

Event Timeline

CorinnaHillebrand_WMDE created this task.Wed, Jan 21, 11:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jan 21, 11:02 AM

AbbanWMDE added a project: WMDE-FUN-Sprint-2026-01-20.Wed, Jan 21, 11:04 AM

CorinnaHillebrand_WMDE updated the task description. (Show Details)Wed, Jan 21, 11:19 AM

CorinnaHillebrand_WMDE updated the task description. (Show Details)

CorinnaHillebrand_WMDE updated the task description. (Show Details)Wed, Jan 21, 11:22 AM

CorinnaHillebrand_WMDE updated the task description. (Show Details)Wed, Jan 21, 11:30 AM

CorinnaHillebrand_WMDE updated the task description. (Show Details)Wed, Jan 21, 11:42 AM

CorinnaHillebrand_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2026-01-13 board.Wed, Jan 21, 11:46 AM

Update:

I deployed the current fundraising-backend main to test and prod. (That didn't fix anything)

I cleared the status of the affected membership manually in our DB (removed moderation reason "AMOUNT TOO HIGH", cleared the status) for now as a quick fix.

This needs further investigation.

fix for the broken membership detail view:
https://github.com/wmde/fundraising-backend/pull/1211

CorinnaHillebrand_WMDE claimed this task.Wed, Jan 21, 4:20 PM

AbbanWMDE moved this task from Doing to Test on the WMDE-FUN-Sprint-2026-01-13 board.Thu, Jan 22, 7:27 AM

AbbanWMDE moved this task from Test to Deploy to Test on the WMDE-FUN-Sprint-2026-01-13 board.

AbbanWMDE moved this task from Todo to Deploy to Test on the WMDE-FUN-Sprint-2026-01-20 board.Thu, Jan 22, 7:45 AM

CorinnaHillebrand_WMDE set the point value for this task to 5.Thu, Jan 22, 9:45 AM

CorinnaHillebrand_WMDE moved this task from Backlog to Current Sprint on the WMDE-Fundraising-Tech board.

CorinnaHillebrand_WMDE moved this task from Deploy to Test to Deploy on the WMDE-FUN-Sprint-2026-01-20 board.Thu, Jan 22, 12:57 PM

CorinnaHillebrand_WMDE moved this task from Deploy to Done on the WMDE-FUN-Sprint-2026-01-20 board.Thu, Jan 22, 1:05 PM

CorinnaHillebrand_WMDE moved this task from Done to Doing on the WMDE-FUN-Sprint-2026-01-20 board.

created a new membership 74286 to test,
on the day of creation the moderation status was still editable,
24h later (after a backup happened) "unlock" returns the 500 again

CorinnaHillebrand_WMDE added a comment.Thu, Jan 22, 2:59 PM

This comment was removed by CorinnaHillebrand_WMDE.

I did some investigation,
the error of memberships not being "approvable" at the next day was caused by the following:

in approveMembershipApplication(..) we call the method getUnexportedMembershipApplicationById( $membershipApplicationId ); to retrieve the membership application from the database
BUT ONLY if it was not anonymized already.

The method checks currently whether a backup timestamp is set (which was the case for the failing membership instances).

-> it now needs to be checked what condition should correctly be applied here,
the backup-timestamp should not be taken for that
https://github.com/wmde/fundraising-memberships/pull/306

CorinnaHillebrand_WMDE moved this task from Doing to Blocked externally on the WMDE-FUN-Sprint-2026-01-20 board.Fri, Jan 23, 9:05 AM

CorinnaHillebrand_WMDE moved this task from Blocked externally to Doing on the WMDE-FUN-Sprint-2026-01-20 board.

CorinnaHillebrand_WMDE added a project: WMDE-FUN-Sprint-2026-02-03.Tue, Feb 3, 10:58 AM

AbbanWMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2026-02-03 board.Tue, Feb 3, 11:00 AM

CorinnaHillebrand_WMDE updated the task description. (Show Details)Tue, Feb 3, 3:31 PM

CorinnaHillebrand_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2026-02-03 board.Fri, Feb 13, 5:46 PM

CorinnaHillebrand_WMDE added a project: WMDE-FUN-Sprint-2026-02-17.Tue, Feb 17, 10:52 AM

CorinnaHillebrand_WMDE changed the point value for this task from 5 to 1.

AbbanWMDE moved this task from Todo to Deploy to Test on the WMDE-FUN-Sprint-2026-02-17 board.Tue, Feb 17, 10:55 AM

moiikana closed https://github.com/wmde/fundraising-memberships/pull/306

Fix broken membership moderation approval

https://github.com/wmde/fundraising-backend/pull/1218