Right now we're doing toasts a little ad-hoc. We have precedents in paste check, add reference, etc.
Questions
- Can we bring the existing toasts in various checks into a helper function in BaseEditCheck and define them by configuration?
- Can we move success/failure toast calls out of act() entirely, perhaps providing an override interface?
Checklist
- Answer the questions above
- File implementation ticket if appropriate
- File follow-up ticket to ensure toasts are up to date eg on T413420 and T413421 and any other ECs tagged https://phabricator.wikimedia.org/tag/visualeditor_suggestion_mode/