Page MenuHomePhabricator
Create Task
Maniphest T415210

Deprecate and remove mw.eventLog.submitClick()
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Description

mw.eventLog.submitClick is currently only being used by one instrument and the aim is to remove that code by February 2026, according to the comment included in the mentioned code. That's the perfect opportunity to deprecate and remove the mentioned function as part of T408059: [GOAL] Tidy up EventLogging, as we are planning to do with mw.eventLog.newInstrument

Acceptance

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ext.eventLogging.core: Removed `mw.eventLog.submitClick`Santiago Facimediawiki/extensions/EventLoggingmaster+0 -2
Migration of 'From Wikidata' tracker from eventLog to using TestKitchenSeanleong-wmdemediawiki/extensions/Wikibasemaster+37 -12
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT408059 [GOAL] Tidy up EventLogging
 ResolvedSfaciT415210 Deprecate and remove mw.eventLog.submitClick()

Event Timeline

Sfaci created this task.Jan 21 2026, 5:02 PM
Restricted Application added a project: Data-Engineering. · View Herald TranscriptJan 21 2026, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sfaci added a parent task: T408059: [GOAL] Tidy up EventLogging.Jan 21 2026, 5:02 PM
Sfaci updated the task description. (Show Details)Jan 21 2026, 5:06 PM
cjming mentioned this in T408059: [GOAL] Tidy up EventLogging.Jan 21 2026, 8:54 PM
phuedx renamed this task from Deprecated and remove mw.eventLog.submitClick() to Deprecate and remove mw.eventLog.submitClick().Jan 22 2026, 9:13 AM
phuedx added a project: Technical-Debt.
Milimetric moved this task from Incoming (new tickets) to Tag with Radar on the Data-Engineering board.Jan 22 2026, 5:18 PM
Milimetric added a project: Data-Engineering-Radar.
Milimetric subscribed.

watching, please add us if you need review / brainbouncing

phuedx moved this task from Incoming to Tidy up EventLogging on the Test Kitchen board.Feb 12 2026, 10:34 AM
seanleong-WMDE mentioned this in T417510: [ENG] Implement new tracking implementation for no. of clicks to WD on Databox.Feb 15 2026, 8:16 PM
gerritbot added a comment.Mar 4 2026, 8:51 AM

Change #1247924 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[mediawiki/extensions/Wikibase@master] Migration of 'From Wikidata' tracker from eventLog to using TestKitchen

https://gerrit.wikimedia.org/r/1247924

gerritbot added a project: Patch-For-Review.Mar 4 2026, 8:51 AM
JVanderhoop-WMF assigned this task to seanleong-WMDE.Mar 10 2026, 4:41 PM
JVanderhoop-WMF moved this task from Tidy up EventLogging to Radar on the Test Kitchen board.
gerritbot added a comment.Mar 16 2026, 12:24 PM

Change #1247924 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migration of 'From Wikidata' tracker from eventLog to using TestKitchen

https://gerrit.wikimedia.org/r/1247924

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2026, 12:32 PM
Sfaci updated the task description. (Show Details)Mar 16 2026, 12:38 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 16 2026, 1:01 PM
seanleong-WMDE removed a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 16 2026, 1:12 PM

Update: T417510 is scheduled to go on prod by 19 March for all wikis and will start collecting metrics on 20 March using TestKitchen. Thanks @Sfaci for the help along the way!

Sfaci updated the task description. (Show Details)Mar 16 2026, 2:42 PM
Sfaci added a comment.Mar 23 2026, 11:57 AM

Update: T417510 is scheduled to go on prod by 19 March for all wikis and will start collecting metrics on 20 March using TestKitchen. Thanks @Sfaci for the help along the way!

I am seeing that the refactored instrument, https://test-kitchen.wikimedia.org/instrument/databox-click-tracker, is now working and their events are being stored in database already. It seems that everything is working fine, so we could consider the instrument as successfully migrated and mw.eventLog.submitClick would be ready to be deprecated and removed

Sfaci added a comment.Mar 23 2026, 12:58 PM

Related the above I have also confirmed that there are no validation errors in EventGate so far

Sfaci removed seanleong-WMDE as the assignee of this task.Mar 23 2026, 3:21 PM
Sfaci edited projects, added: Test Kitchen (Experiment Platform Sprint 21); removed: Test Kitchen.
Sfaci added a subscriber: seanleong-WMDE.
gerritbot added a comment.Mar 24 2026, 10:59 AM

Change #1259922 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/EventLogging@master] ext.eventLogging.core: Removed `mw.eventLog.submitClick`

https://gerrit.wikimedia.org/r/1259922

gerritbot added a project: Patch-For-Review.Mar 24 2026, 10:59 AM
Sfaci claimed this task.Mar 24 2026, 11:00 AM
Sfaci set the point value for this task to 1.
Sfaci moved this task from Ready for Development to In Progress on the Test Kitchen (Experiment Platform Sprint 21) board.
Sfaci updated the task description. (Show Details)Mar 24 2026, 11:05 AM
Sfaci added subscribers: cjming, phuedx.Mar 24 2026, 12:04 PM

@phuedx @cjming

The patch above does the minimum necessary to "remove" that function from EventLogging but I'm considering leaving untouched metrics-platform, where the function code resides

Do we want to update metrics-platform accordingly? I mean by removing also the corresponding function from there. We are no longer using those client libraries so I'm assuming that we will end up archiving/removing them at some point so it wouldn't make sense to update, deploy and so on according to this and other upcoming changes we are going to work on

We have already a task to T415260: Remove PHP Metrics Platform SDK so I'm guessing we will do something similar with the Metrics Platform JS SDK (or maybe we just have to archive that repo as we did for the MetricsPlatform extension)

What do you think?

Sfaci moved this task from In Progress to Needs Review on the Test Kitchen (Experiment Platform Sprint 21) board.Mar 24 2026, 12:04 PM
phuedx added a comment.Mar 25 2026, 11:51 AM

@Sfaci: I like the idea of tidying up repos/data-engineering/metrics-platform separately.

phuedx moved this task from Needs Review to To Deploy on the Test Kitchen (Experiment Platform Sprint 21) board.Mar 25 2026, 11:51 AM
phuedx updated the task description. (Show Details)
gerritbot added a comment.Mar 25 2026, 12:06 PM

Change #1259922 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] ext.eventLogging.core: Removed `mw.eventLog.submitClick`

https://gerrit.wikimedia.org/r/1259922

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2026, 12:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 25 2026, 1:00 PM
KReid-WMF moved this task from To Deploy to Done on the Test Kitchen (Experiment Platform Sprint 21) board.Apr 2 2026, 5:03 PM
KReid-WMF closed this task as Resolved.Apr 2 2026, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits