Deprecate and remove EventLogging::getMetricsPlatformClient()
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	phuedx
	Thu, Jan 22, 10:45 AM

Description

Ronseal.

Background

EventLogging::getMetricsPlatformClient() is the gateway to the Metrics Platform SDK. The Experiment Platform team are deprecating the Metrics Platform MediaWiki extension and SDKs in favour of the Test Kitchen SDK. EventLogging::getMetricsPlatformClient() should be deprecated and removed.

AC

Any uses of the method are tidied up
- https://codesearch.wmcloud.org/search/?q=getMetricsPlatformClient&files=php%24&excludeFiles=&repos=
The method is deprecated and removed
Supporting code is tidied up
- EventLogging::resetMetricsPlatformClient()
- EventLogging::$metricsPlatformClient()
The deprecation is announced
On-wiki documentation is updated

Related Objects
Search...

Status	Assigned	Task
Open	None	T408059 [GOAL] Tidy up EventLogging
Open	None	T415260 Remove PHP Metrics Platform SDK
Open	None	T415246 Deprecate and remove EventLogging::getMetricsPlatformClient()
Open	None	T415254 Migrate "WikiLambda API" instrument to use the Test Kitchen SDK
Open	Sfaci	T409913 Create PHP equivalent of mw.testKitchen.getInstrument()
Open	phuedx	T367034 TestKitchen Extension: Merge PHP MetricsPlatform client library

Event Timeline

phuedx created this task.Thu, Jan 22, 10:45 AM

Restricted Application added a project: Data-Engineering. · View Herald TranscriptThu, Jan 22, 10:45 AM

phuedx mentioned this in T408059: [GOAL] Tidy up EventLogging.Thu, Jan 22, 10:46 AM

phuedx updated the task description. (Show Details)

phuedx created subtask T415254: Migrate "WikiLambda API" instrument to use the Test Kitchen SDK.Thu, Jan 22, 12:10 PM

phuedx added a parent task: T415260: Remove PHP Metrics Platform SDK.Thu, Jan 22, 1:01 PM

watching, please add us if you need review / brainbouncing

@phuedx are usages like this ($this->metricsClientFactory->newMetricsClient( $context )) implicitly included here? Mentioning just in case. I have found this while looking for others regarding the JS client library

In T415246#11548974, @Sfaci wrote:

@phuedx are usages like this ($this->metricsClientFactory->newMetricsClient( $context )) implicitly included here? Mentioning just in case. I have found this while looking for others regarding the JS client library

Good question, @Sfaci. I would say no – let's keep this task tightly scoped. All instances of MetricsClientFactory#newMetricsClient() (Codesearch) are using the EventLogging.MetricsClientFactory service, which should have its own deprecation task.

In T415246#11561108, @phuedx wrote:

In T415246#11548974, @Sfaci wrote:

@phuedx are usages like this ($this->metricsClientFactory->newMetricsClient( $context )) implicitly included here? Mentioning just in case. I have found this while looking for others regarding the JS client library

Good question, @Sfaci. I would say no – let's keep this task tightly scoped. All instances of MetricsClientFactory#newMetricsClient() (Codesearch) are using the EventLogging.MetricsClientFactory service, which should have its own deprecation task.

ok! Fully agree!
I started already with this by filing a couple of tasks to migrate specific instruments that are using that way (T415650: Migrate ReportIncident PHP instrument to use Test Kitchen SDK and T415654: Migrate CheckUser PHP instrument to use Test Kitchen SDK, for example) so I'll create the pending ones and also the specific task to deprecate that EventLogging.MetricsClientFactory service. And I will link all of them accordingly

I started already with this by filing a couple of tasks to migrate specific instruments that are using that way (T415650: Migrate ReportIncident PHP instrument to use Test Kitchen SDK and T415654: Migrate CheckUser PHP instrument to use Test Kitchen SDK, for example) so I'll create the pending ones and also the specific task to deprecate that EventLogging.MetricsClientFactory service. And I will link all of them accordingly

Done. I have filed T416020: Deprecate and remove EventLogging.MetricsClientFactory service and the needed related ticket to migrate the instruments that are using it at this time

phuedx moved this task from Incoming to Tidy up EventLogging on the Test Kitchen board.Thu, Feb 12, 10:34 AM

Deprecate and remove EventLogging::getMetricsPlatformClient()Open, Needs TriagePublicActions

Description

Background

AC

Related ObjectsSearch...

Event Timeline

Deprecate and remove EventLogging::getMetricsPlatformClient()
Open, Needs TriagePublic
Actions

Related Objects
Search...