Page MenuHomePhabricator

MediaSearch should stop relying on render map config
Closed, ResolvedPublic

Description

We don't want to pregenerate thumbnails any more, which means we would like to set wgUploadThumbnailRenderMap to be empty. Currently we can't do that (cf CR 1224071) because MediaSearch uses it (codesearch) to set the size of files.

This task is to track the work of fixing MediaSearch so we can make UploadThumbnailRenderMap empty and thus stop pregenerating thumbnails.

Event Timeline

MatthewVernon triaged this task as High priority.

To emphasize: MediaSearch does respond with standard sizes but the js uses a config that shouldn't be used.

Change #1236832 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MediaSearch@master] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1236832

Change #1236832 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1236832

Change #1237255 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MediaSearch@wmf/1.46.0-wmf.14] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1237255

Change #1237256 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/MediaSearch@wmf/1.46.0-wmf.13] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1237256

Change #1237256 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.46.0-wmf.13] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1237256

Change #1237255 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.46.0-wmf.14] Stop relying on ThumbRenderMap and use a standard size instead

https://gerrit.wikimedia.org/r/1237255

Mentioned in SAL (#wikimedia-operations) [2026-02-05T17:01:24Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1237256|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]], [[gerrit:1237255|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]]

Mentioned in SAL (#wikimedia-operations) [2026-02-05T17:03:16Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1237256|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]], [[gerrit:1237255|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-02-05T17:15:28Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1237256|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]], [[gerrit:1237255|Stop relying on ThumbRenderMap and use a standard size instead (T415282)]] (duration: 14m 04s)

Change #1237504 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[operations/deployment-charts@master] changeprop-jobqueue: Remove thumbnail render job concurrency

https://gerrit.wikimedia.org/r/1237504

Change #1237504 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop-jobqueue: Remove thumbnail render job concurrency

https://gerrit.wikimedia.org/r/1237504