Page MenuHomePhabricator

'.experiment.sampling_unit' should be equal to one of the allowed values
Open, Needs TriagePublic

Description

What happens?:

We're getting validation errors from our own testing with overridden experiment users, see example from Growth event validation logstash dashboard.

What should have happened instead?:
No events from these users should be sent. This is because ReviseToneInteractionLogger does not behave as the TestKitchen JS client which drops traffic from overridden users.

Once T415277 is resolved, GE can update its client to the experiment pre-configured which will take care of this.

Event Timeline

Change #1230391 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix: avoid logging traffic from overridden experiment users

https://gerrit.wikimedia.org/r/1230391

Change #1230391 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix: avoid logging traffic from overridden experiment users

https://gerrit.wikimedia.org/r/1230391

Change #1233116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.12] fix: avoid logging traffic from overridden experiment users

https://gerrit.wikimedia.org/r/1233116

Mentioned in SAL (#wikimedia-operations) [2026-01-26T14:32:27Z] <sgimeno@deploy2002> Started scap sync-world: Backport for [[gerrit:1233116|fix: avoid logging traffic from overridden experiment users (T415294)]], [[gerrit:1233117|fix: avoid displaying incorrect additional userpage link (T415291)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-26T14:34:34Z] <sgimeno@deploy2002> sgimeno: Backport for [[gerrit:1233116|fix: avoid logging traffic from overridden experiment users (T415294)]], [[gerrit:1233117|fix: avoid displaying incorrect additional userpage link (T415291)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-26T14:39:21Z] <sgimeno@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233116|fix: avoid logging traffic from overridden experiment users (T415294)]], [[gerrit:1233117|fix: avoid displaying incorrect additional userpage link (T415291)]] (duration: 06m 54s)