| Ammarpad | |
| Jan 22 2026, 6:26 PM |
| F71592192: image.png | |
| Jan 22 2026, 9:17 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Nothing
What should have happened instead?:
Overflow menu should open, with (at least) "Edit" menu item.
Some of the reply buttons work for me, others display the message "Could not find the comment you're replying to on the page. It might have been deleted or moved to another page.".
There's a console error:
jQuery.Deferred exception: can't access property "type", threadItem is null overflowMenu.js/init/...
The threadItems store has the wrong IDs:
They should be h-editsummaries-2017-08-04T11:07:00.000Z etc.
It looks like this was caused by some recent changes to heading syntax. They should be reverted immediately, we need to be very careful when modifying heading syntax, as we learnt from the last time we restructured them for accessibility.
The change was: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1220393 which merged last Thursday, and so hit group 2 today.
Change #1230451 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/MobileFrontend@master] Revert "Toggler: Update heading toggler to match WAI ARIA pattern"
Change #1230454 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/MobileFrontend@wmf/1.46.0-wmf.12] Revert "Toggler: Update heading toggler to match WAI ARIA pattern"
Change #1230454 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.46.0-wmf.12] Revert "Toggler: Update heading toggler to match WAI ARIA pattern"
Mentioned in SAL (#wikimedia-operations) [2026-01-22T22:08:24Z] <kemayo@deploy2002> Started scap sync-world: Backport for [[gerrit:1230454|Revert "Toggler: Update heading toggler to match WAI ARIA pattern" (T415303 T407908)]]
Mentioned in SAL (#wikimedia-operations) [2026-01-22T22:10:23Z] <kemayo@deploy2002> kemayo: Backport for [[gerrit:1230454|Revert "Toggler: Update heading toggler to match WAI ARIA pattern" (T415303 T407908)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2026-01-22T22:15:07Z] <kemayo@deploy2002> Finished scap sync-world: Backport for [[gerrit:1230454|Revert "Toggler: Update heading toggler to match WAI ARIA pattern" (T415303 T407908)]] (duration: 06m 43s)
Okay, that change has been reverted, and the revert has been backported. Reader Experience Team has been notified via their channel about what was done.
Change #1230451 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert "Toggler: Update heading toggler to match WAI ARIA pattern"
for QS-Test-Automation and anyone else who might be able to answer:
Is there an opportunity to review existing automation (UI/Integration) for DiscussionTools and see if this could have been prevented through automation (potentially with @EAkinloose or @Ryasmeen to help understand the scope)?
Assuming the answer is yes: what tests would need to be created to do this?