Page MenuHomePhabricator

Add serviceops new to the monitored channels on IRC bot/wikibugs
Closed, ResolvedPublic

Description

With all our tasks being moved to the serviceops new tag, it need to be reflected in the IRC bot config for #wikimedia-serviceops

Event Timeline

MLechvien-WMF moved this task from Inbox to In Progress on the ServiceOps new board.

I modified the alternate tag of serviceops new and I believe this should now be reflected by IRC bot/wikibugs to the -operations channel

The semi-secret magic here was that the #wikimedia-operations channel config matches all Phabricator tags and alternate tags that start with sre- (case insensitive). The case insensitive part is likely non-obvious from reading the current config file.

channels.yaml (partial)
channels:

  "#wikimedia-operations":
    "ops(-.*)?":
    "puppet":
    "Blocked-on-Operations":
    "SRE(-.*)?":
hashar subscribed.

Matthieu and I had a chat about it. He added to the project an additional hashtag #sre-serviceops-new (link to change) but I don't think Wikibugs2 deal with them. As far as I understand it only inspects the project canonical name.

@MLechvien-WMF you would need to add an entry that adds the #wikimedia-serviceops channel and register to the https://phabricator.wikimedia.org/tag/serviceops_new tag:

channels:
  "#wikimedia-serviceops":
    "serviceops_new":

https://www.mediawiki.org/wiki/Wikibugs#Configuring_channels has a note about wikibugs requiring to have modes vV, I have confirmed that is already the case:

/msg ChanServ flags #wikimedia-serviceops
...
11       wikibugs               +Vv                  [modified 4y 31w 0d ago, on Jun 24 08:32:44 2021 +0000, by ircservserv-wm]

Matthieu and I had a chat about it. He added to the project an additional hashtag #sre-serviceops-new (link to change) but I don't think Wikibugs2 deal with them. As far as I understand it only inspects the project canonical name.

I apparently remembered more about this in March 2024 when I was discussing T87825: Match on usage of Additional Hashtags, so that project renames don't break the bot in T87825#9618460. @hashar is correct that the display name of the project is what is matched by the regex rules in channels.yaml. That means that matching happens on ServiceOps new rather than #serviceops_new or the alternate tags. I think where I may have gotten myself confused in IRC chat with @MLechvien-WMF was in believing that tasks marked with serviceops were already being reported to #wikimedia-operations. For that to work it would have had to be matching on alternate hashtags as I hallucinated in T415352#11550573.

@MLechvien-WMF you would need to add an entry that adds the #wikimedia-serviceops channel and register to the https://phabricator.wikimedia.org/tag/serviceops_new tag:

channels:
  "#wikimedia-serviceops":
    "serviceops_new":

https://www.mediawiki.org/wiki/Wikibugs#Configuring_channels has a note about wikibugs requiring to have modes vV, I have confirmed that is already the case:

/msg ChanServ flags #wikimedia-serviceops
...
11       wikibugs               +Vv                  [modified 4y 31w 0d ago, on Jun 24 08:32:44 2021 +0000, by ircservserv-wm]

The task description says that #wikimedia-operations is the desired reporting channel, not #wikimedia-serviceops. Is that incorrect? Either way the matcher should be "serviceops new" (or "serviceops.*" if serviceops should be reported to the same channel). The match is on the project's display name rather than any of the associated tags.

matthieulec updated https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/65

Update list of channels following our changes in Phabricator workboard

I got confused on the exact channel, nothing should go to wikimedia-operations, I fixed the description.

During last week SRE summit we decided to take that opportunity to route automated updates to a new channel #wikimedia-serviceops-feed.

The intent is to separate our communication with other teams (on the existing #wikimedia-serviceops channel) from the automated bot messages (on that new -feed channel).

I created the channel and gave wikibugs the -vV rights, and I sent a MR your way @bd808 .

bd808 merged https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/65

Update list of channels following our changes in Phabricator workboard

Config change was merged and has been pushed to the wikibugs api server. Does this comment lead to the bot joining #wikimedia-serviceops-feed and announcing the task change?

#wikimedia-serviceops-feed
[22:43]  wikibugs (~wikibugs@wikimedia/bot/pywikibugs) joined the channel
[22:43]  < wikibugs> ServiceOps new, Wikibugs: Add serviceops new to the monitored channels on IRC bot/wikibugs - https://phabricator.wikimedia.org/T415352#11585494 (bd808) Config change was merged and has been pushed to the wikibugs api server. Does this comment lead to the bot joining `#wikimedia-serviceops-feed` and annou...
[22:43] ChanServ sets mode +v wikibugs