Page MenuHomePhabricator
Create Task
Maniphest T415369

Suggested Investigations: Instrument the Filters
Closed, ResolvedPublic
Actions

Description

Summary

We recently implemented a dialog to filter results in the CheckUser-SuggestedInvestigations interface. We should instrument this to measure it's impact

Background

Technical notes

  • We likely want to update the page_load event to include what filters are applied on the page
  • We may want to instrument the dialog itself, looking for uses which didn't result in actually making any changes to the filters

Acceptance criteria

  • The instrumentation is added

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Follow-up: SI: Add applied filters to page_load instrumentation eventmediawiki/extensions/CheckUsermaster+2 -2
Follow-up: SI: Add applied filters to page_load instrumentation eventmediawiki/extensions/CheckUserwmf/1.46.0-wmf.13+2 -2
SI: Add applied filters to page_load instrumentation eventmediawiki/extensions/CheckUsermaster+49 -20
SI: Add applied filters to page_load instrumentation eventmediawiki/extensions/CheckUserwmf/1.46.0-wmf.13+49 -20
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Fri, Jan 23, 2:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Jan 23, 2:07 PM
Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Fri, Jan 23, 2:08 PM

Let's update the page_load instrumentation first. We can decide if additional instrumentation is needed later

Dreamy_Jazz renamed this task from Suggested Investigations: Instrument the Filters dialog to Suggested Investigations: Instrument the Filters.Fri, Jan 23, 2:09 PM
gerritbot added a comment.Fri, Jan 23, 2:10 PM

Change #1230925 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1230925

gerritbot added a project: Patch-For-Review.Fri, Jan 23, 2:10 PM
Dreamy_Jazz claimed this task.Fri, Jan 23, 2:14 PM
CodeReviewBot added a comment.Fri, Jan 23, 2:38 PM

dreamyjazz opened https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/108

Add applied_filters to suggested_investigations/interaction stream

Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.EditedFri, Jan 23, 2:39 PM

https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/108 needs to be merged before any other patches can be worked on

Dreamy_Jazz moved this task from Needs review to In progress on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Sat, Jan 24, 9:48 PM
CodeReviewBot added a comment.Mon, Jan 26, 6:09 PM

dreamyjazz merged https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/108

Add applied_filters to suggested_investigations/interaction stream

Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Tue, Jan 27, 2:28 PM
gerritbot added a comment.Tue, Jan 27, 3:07 PM

Change #1233736 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.46.0-wmf.13] SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233736

gerritbot added a comment.Tue, Jan 27, 3:21 PM

Change #1233736 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.46.0-wmf.13] SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233736

Stashbot added a comment.Tue, Jan 27, 3:22 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T15:22:16Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1233736|SI: Add applied filters to page_load instrumentation event (T415369)]]

Stashbot added a comment.Tue, Jan 27, 3:24 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T15:24:25Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1233736|SI: Add applied filters to page_load instrumentation event (T415369)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Tue, Jan 27, 3:30 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T15:30:14Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233736|SI: Add applied filters to page_load instrumentation event (T415369)]] (duration: 07m 58s)

gerritbot added a comment.Tue, Jan 27, 3:33 PM

Change #1230925 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1230925

gerritbot added a comment.Tue, Jan 27, 3:47 PM

Change #1233742 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Follow-up: SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233742

gerritbot added a comment.Tue, Jan 27, 3:47 PM

Change #1233743 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.46.0-wmf.13] Follow-up: SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233743

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Tue, Jan 27, 4:00 PM
gerritbot added a comment.Tue, Jan 27, 4:01 PM

Change #1233743 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.46.0-wmf.13] Follow-up: SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233743

Stashbot added a comment.Tue, Jan 27, 4:01 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T16:01:46Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1233743|Follow-up: SI: Add applied filters to page_load instrumentation event (T415369)]]

Stashbot added a comment.Tue, Jan 27, 4:03 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T16:03:54Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1233743|Follow-up: SI: Add applied filters to page_load instrumentation event (T415369)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

gerritbot added a comment.Tue, Jan 27, 4:11 PM

Change #1233742 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Follow-up: SI: Add applied filters to page_load instrumentation event

https://gerrit.wikimedia.org/r/1233742

Stashbot added a comment.Tue, Jan 27, 4:13 PM

Mentioned in SAL (#wikimedia-operations) [2026-01-27T16:13:04Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233743|Follow-up: SI: Add applied filters to page_load instrumentation event (T415369)]] (duration: 11m 18s)

Dreamy_Jazz closed this task as Resolved.Tue, Jan 27, 4:30 PM
Dreamy_Jazz moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.

Verified on testwiki that the filters are added to the page_load instrumentation.

We decided we don't need additional instrumentation for how users use the dialog (i.e. for failed uses of the dialog)

Maintenance_bot removed a project: Patch-For-Review.Tue, Jan 27, 4:31 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.13; 2026-01-27); removed MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Tue, Jan 27, 5:00 PM
hector.arroyo moved this task from Backlog to Done on the CheckUser-SuggestedInvestigations board.Mon, Feb 2, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits