Page MenuHomePhabricator

Migrate all instruments using mw.eventLog.submitInteraction to mw.testKitchen.getInstrument()
Closed, ResolvedPublic5 Estimated Story Points

Description

Description

Before T415362: Deprecate and remove mw.eventLog.submitInteraction() we should migrate all instruments that are using mw.eventLog.submitInteraction so they use mw.testKitchen.getInstrument instead

Acceptance criteria

Event Timeline

JVanderhoop-WMF set the point value for this task to 5.

All of these instruments are currently active, though they could be... no longer valuable.

@phuedx proposes deletion webUI actions -- it was an old migration attempt that did not complete. Confirm with @jwang.

SessionLength mix in - there is a newer version of the mixin that only uses instrument.send() and experiment.send() -- so this might be a piece of code that we can easily delete. @phuedx says "delete them both"

For all of these instruments, we should reach out to the owners to say "we're going to delete this" and only if you need it, we will migrate it.

Change #1306386 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] Remove webUIClick instrument

https://gerrit.wikimedia.org/r/1306386

Change #1306387 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] Remove webUIScroll instrument

https://gerrit.wikimedia.org/r/1306387

Change #1306389 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] Remove sessionLength mixin

https://gerrit.wikimedia.org/r/1306389

Change #1306454 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Remove webUIScroll config

https://gerrit.wikimedia.org/r/1306454

Change #1306389 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove sessionLength mixin

https://gerrit.wikimedia.org/r/1306389

Change #1307237 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikiLambda@master] Migrate to mw.testKitchen.getInstrument()#send() in eventLogUtils

https://gerrit.wikimedia.org/r/1307237

Change #1307243 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Translate@master] ext.translate.eventlogginghelpers: Migrate to Test Kitchen instrument

https://gerrit.wikimedia.org/r/1307243

Change #1307252 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ContentTranslation@master] minT: Migrate useEventLogging to Test Kitchen instrument

https://gerrit.wikimedia.org/r/1307252

Change #1306386 abandoned by Clare Ming:

[mediawiki/extensions/WikimediaEvents@master] Remove webUIClick instrument

Reason:

in favor of migrating to Test Kitchen

https://gerrit.wikimedia.org/r/1306386

Change #1308266 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Migrate webUIClick to Test Kitchen instrument

https://gerrit.wikimedia.org/r/1308266

Change #1307237 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Migrate to mw.testKitchen.getInstrument()#send() in eventLogUtils

https://gerrit.wikimedia.org/r/1307237

One of the CX app is using mw.eventLog.submit(...), does it need to be migrated as well?

cjming updated the task description. (Show Details)

for WebUIScroll instrument - mediawiki.web_ui_scroll_migrated should maybe be deleted - added to ACs

One of the CX app is using mw.eventLog.submit(...), does it need to be migrated as well?

thanks @SBisson ! which app? can you provide link? i can add it to ACs if it should be updated too

One of the CX app is using mw.eventLog.submit(...), does it need to be migrated as well?

thanks @SBisson ! which app? can you provide link? i can add it to ACs if it should be updated too

I would say there is no plan to replace/migrate mw.eventLog.submit. Not sure which is the right expression to explain this but I would say it's still a way to use EventLogging as a client for Event Platform without using Test Kitchen. That function is still being used in several places mainly with schemas that don't inherit from the Test Kitchen ones (for example the sessionTick instrument, that uses /analytics/session_tick/2.0.0 as schema. So refactoring all those usages would require additional effort and I think we are not yet planning to work on that.

I would say that, for now, we are just removing Test Kitchen functionalities from EventLogging as a way to tidy up that extension. I guess that, when Test Kitchen, the platform, didn't have its own extension, we used EventLogging as the place to implement some functionality. And now we are removing it from there because now the TestKitchen extension can provide it directly.

I would say that, for now, we are just removing Test Kitchen functionalities from EventLogging as a way to tidy up that extension. I guess that, when Test Kitchen, the platform, didn't have its own extension, we used EventLogging as the place to implement some functionality. And now we are removing it from there because now the TestKitchen extension can provide it directly.

Very much this. The goal is to simplify EventLogging by removing all Metrics Platform / Test Kitchen functionality from it.

Change #1306387 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove webUIScroll instrument

https://gerrit.wikimedia.org/r/1306387

Change #1307252 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] minT: Migrate useEventLogging to Test Kitchen instrument

https://gerrit.wikimedia.org/r/1307252

Change #1313234 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/TestKitchen@master] docs: Remove mw.eventLog.submitInteraction from JSDoc link map

https://gerrit.wikimedia.org/r/1313234

Change #1313751 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] webUIClick: Replace deprecated submitInteraction() with submit()

https://gerrit.wikimedia.org/r/1313751

Change #1308266 abandoned by Clare Ming:

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Migrate webUIClick to Test Kitchen instrument

Reason:

in favor of I82b5a3183921187057b0d3a0f22883305f5b81b8

https://gerrit.wikimedia.org/r/1308266

Change #1313923 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] EventStreamConfig: Remove unused web_ui_scroll* streams

https://gerrit.wikimedia.org/r/1313923

Change #1313234 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] docs: Remove mw.eventLog.submitInteraction from JSDoc link map

https://gerrit.wikimedia.org/r/1313234

Change #1307243 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ext.translate.eventlogginghelpers: Migrate to Test Kitchen instrument

https://gerrit.wikimedia.org/r/1307243

Change #1313751 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] webUIClick: Replace deprecated submitInteraction() with submit()

https://gerrit.wikimedia.org/r/1313751