Page MenuHomePhabricator

Possible impact to user styles modifying Vector 2022 header
Closed, DeclinedPublic

Description

We are modifying the HTML markup for the sticky header. Per our frontend stable policy this is not a stable interface but as a courtesy I wanted to let maintainers of user styles know they will need to update their CSS.

On short term, please update your selector to #vector-sticky-header .mw-page-title-main (please note that while #vector-sticky-header is also not considered a stable interface it is less likely to change).
https://global-search.toolforge.org/?q=%5C.vector-sticky-header-context-bar-primary&regex=1&namespaces=&title=

As a reminder per our stable policy, please request new APIs if this functionality is important to avoid it breaking again (see
https://www.mediawiki.org/wiki/Stable_interface_policy/Frontend#Communication for more information)

Event Timeline

Hey @Jdlrobson-WMF @UOzurumba, I came across this task. Just a few questions:

  • For cross-referencing, is there a related task that contains the work that will be done / has been done regarding this?
  • Has this already been announced (noting that this is currently in the 'Not ready to announce' column of User-notice)? If not, when should it be announced / should it have already been announced?

I forget... it was too long ago.

I think we were going to do this as part of T414993: Vector TOC in Sticky header is styled incorrectly and empty when changing viewports but a change was reverted and we fixed it in another way.

The user notice is not wrong but we can repost it again if this needs to be removed in future for a different reason.