Page MenuHomePhabricator
Create Task
Maniphest T415433

Request Account button disappears in 1.45
Closed, ResolvedPublicBUG REPORT
Actions

Description

I previously approved a change from @alistair3149 to change the ID on the Request Account link so that it wouldn't reuse the same id as usual Create Account link. This was a mistake, though, because createaccount is hard-coded into Vector and, beside this, wikis (such as icannwiki) depend on the CSS id.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Undo ID changemediawiki/extensions/ConfirmAccountREL1_45+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Sat, Jan 24, 3:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Jan 24, 3:04 AM
MarkAHershberger added a comment.Sat, Jan 24, 3:13 AM

Gah, previously changed for T407441. Needs to be cherry-picked for REL1_45.

gerritbot added a comment.Sat, Jan 24, 3:14 AM

Change #1231135 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/extensions/ConfirmAccount@REL1_45] Undo ID change

https://gerrit.wikimedia.org/r/1231135

gerritbot added a project: Patch-For-Review.Sat, Jan 24, 3:14 AM
gerritbot added a comment.Sat, Jan 24, 3:29 AM

Change #1231135 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@REL1_45] Undo ID change

https://gerrit.wikimedia.org/r/1231135

Maintenance_bot removed a project: Patch-For-Review.Sat, Jan 24, 3:31 AM
MarkAHershberger closed this task as Resolved.Sat, Jan 24, 3:43 AM
MarkAHershberger claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits