Test failures from MoveLeadParagraphTransformTest::testIdentifyInfoboxElement on PHP 8.4
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When running composer phpunit -- extensions/MobileFrontend --filter MoveLeadParagraphTransformTest locally on PHP 8.4, MoveLeadParagraphTransformTest::testIdentifyInfoboxElement has 5 test failures:

1) MoveLeadParagraphTransformTest::testIdentifyInfoboxElement with data set #1 ('<p></p><div class="infobox"></div>', '/html/body/div', 'Simple infobox')
Simple infobox
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/html/body/div'
+'/*/*[2]/*[2]'

/[...]/extensions/MobileFrontend/tests/phpunit/unit/transforms/MoveLeadParagraphTransformTest.php:39

2) MoveLeadParagraphTransformTest::testIdentifyInfoboxElement with data set #2 ('<p></p><div class="mw-stack">...</div>', '/html/body/div', 'Infobox wrapped in an known container')
Infobox wrapped in an known container
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/html/body/div'
+'/*/*[2]/*[2]'

/[...]/extensions/MobileFrontend/tests/phpunit/unit/transforms/MoveLeadParagraphTransformTest.php:39

3) MoveLeadParagraphTransformTest::testIdentifyInfoboxElement with data set #3 ('<p></p><div><table class="inf...</div>', '/html/body/div/table', 'Infobox wrapped in an unknown...tainer')
Infobox wrapped in an unknown container
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/html/body/div/table'
+'/*/*[2]/*[2]/*'

/[...]/extensions/MobileFrontend/tests/phpunit/unit/transforms/MoveLeadParagraphTransformTest.php:39

4) MoveLeadParagraphTransformTest::testIdentifyInfoboxElement with data set #4 ('<p></p><div class="thumb trig...</div>', '/html/body/div', 'Thumbnail')
Thumbnail
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/html/body/div'
+'/*/*[2]/*[2]'

/[...]/extensions/MobileFrontend/tests/phpunit/unit/transforms/MoveLeadParagraphTransformTest.php:39

5) MoveLeadParagraphTransformTest::testIdentifyInfoboxElement with data set #5 ('<p></p><figure></figure>', '/html/body/figure', 'Thumbnail (Parsoid)')
Thumbnail (Parsoid)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/html/body/figure'
+'/*/*[2]/*[2]'

/[...]/extensions/MobileFrontend/tests/phpunit/unit/transforms/MoveLeadParagraphTransformTest.php:39

This is also seen on CI's PHP 8.4 check experimental tests -- e.g. https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php84/53/console.

Software versions:

mediawiki/core: d70bfcbb7d5d
mediawiki/extensions/MobileFrontend: e05f6d5f17ef

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix testIdentifyInfoboxElement	Matthias Mullie	mediawiki/extensions/MobileFrontend	master	+15 -30
	MoveLeadParagraphTransformTest.testIdentifyInfoboxElement: Skip for PHP 8.4+	Jforrester	mediawiki/extensions/MobileFrontend	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T413223 Migrate Wikimedia production from PHP 8.3 to PHP 8.5
Resolved	Jdforrester-WMF	T386108 Make PHP 8.4 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Resolved	Jdforrester-WMF	T415955 Ensure that all Wikimedia-deployed code passes PHP 8.4 CI
Resolved	matthiasmullie	T415448 Test failures from MoveLeadParagraphTransformTest::testIdentifyInfoboxElement on PHP 8.4

Event Timeline

A_smart_kitten created this task.Jan 24 2026, 3:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2026, 3:31 PM

A_smart_kitten moved this task from Backlog to Wikimedia production on the PHP 8.4 support board.Jan 24 2026, 3:32 PM

A_smart_kitten mentioned this in T386108: Make PHP 8.4 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.

Does this test fail consistently when Parsoid/legacy parser is enabled?

To confirm, do you mean when ext:ParserMigration is installed & $wgParserMigrationEnableParsoidArticlePages is set to true/false? If so -- yep, the tests fail every time I run them locally, whether that config variable is set to true or false.

HSwan-WMF triaged this task as Medium priority.Jan 29 2026, 5:59 PM

Jdforrester-WMF mentioned this in T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI.Jan 29 2026, 9:29 PM

Jdlrobson-WMF moved this task from Untriaged to MobileFormatter on the MobileFrontend board.Feb 10 2026, 7:21 PM

Jdlrobson-WMF edited projects, added: MobileFrontend (MobileFormatter); removed: MobileFrontend.

HSwan-WMF moved this task from Incoming/Inbox to Backlog on the Reader Growth Team board.Feb 10 2026, 9:14 PM

Hi Readers team, this is the last blocker to enabling PHP 8.4 in CI. Do you have an estimate for when this will get fixed?

Jdforrester-WMF added a parent task: T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI.Feb 13 2026, 2:38 PM

Change #1240777 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@master] MoveLeadParagraphTransformTest.testIdentifyInfoboxElement: Skip for PHP 8.4+

https://gerrit.wikimedia.org/r/1240777

gerritbot added a project: Patch-For-Review.Feb 19 2026, 6:37 PM

@Jdforrester-WMF Hey there! We are working toward an experiment launch on Tuesday, the 24th. Can we wait on this a little longer until we meet our deadline, or will that be too painful?

Change #1240777 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MoveLeadParagraphTransformTest.testIdentifyInfoboxElement: Skip for PHP 8.4+

https://gerrit.wikimedia.org/r/1240777

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2026, 12:30 AM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.17; 2026-02-24).Feb 20 2026, 1:00 AM

In T415448#11634572, @HSwan-WMF wrote:

@Jdforrester-WMF Hey there! We are working toward an experiment launch on Tuesday, the 24th. Can we wait on this a little longer until we meet our deadline, or will that be too painful?

That's fine, yes — the overall work this blocks needs to get done in the next month or so, but it's not urgent.

HSwan-WMF moved this task from Backlog to Needs Refinement on the Reader Growth Team board.Feb 24 2026, 10:08 PM

SherryYang-WMF set the point value for this task to 3.Feb 25 2026, 5:50 PM

SherryYang-WMF moved this task from Needs Refinement to Ready on the Reader Growth Team board.Feb 25 2026, 6:01 PM

Change #1245293 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MobileFrontend@master] Fix testIdentifyInfoboxElement

https://gerrit.wikimedia.org/r/1245293

gerritbot added a project: Patch-For-Review.Feb 27 2026, 10:12 AM

matthiasmullie claimed this task.Feb 27 2026, 10:12 AM

matthiasmullie edited projects, added: Reader Growth Team (Sprint 3 (Feb 17 - Mar 2) Q3 25/26); removed: Reader Growth Team.

matthiasmullie moved this task from Committed to Code Review on the Reader Growth Team (Sprint 3 (Feb 17 - Mar 2) Q3 25/26) board.Feb 27 2026, 11:18 AM

Change #1245293 merged by jenkins-bot: