Page MenuHomePhabricator

[Refactor] Show main content in the ReferenceSearchWidget of a sub-ref node without relying on a main node
Closed, ResolvedPublic

Description

Context

Currently the search results will be rendered using the getAllRefsInReflistOrder in MWGroupReferences. MWGroupReferences builds an index for refs and subrefs using mainRefKey. That needs to change. We need to do something similar but with the mainListIndex only.

Task
  • Build the search results correctly independent of main ref nodes in main+details cases
  • Make sure the main content can be seen independent of main ref nodes in main+details cases

See also T419849: [Refactor] Reimplement group references structure without relying on synthetic ref nodes or list key

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
WMDE-Fisch renamed this task from [Refactor] Rewrite any MWReferenceNode dependencies related to the MWReferenceSearchWidget to [Refactor] Render search results list using the the mainListIndex in MWReferenceSearchWidget.Feb 2 2026, 11:08 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch renamed this task from [Refactor] Render search results list using the the mainListIndex in MWReferenceSearchWidget to [Refactor] Render search results withouth relying on `mainRefKey` in MWReferenceSearchWidget.Feb 2 2026, 11:34 AM
WMDE-Fisch updated the task description. (Show Details)

Change #1236764 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [WIP] Add listIndex support for getAllRefsInReflistOrderByIndex

https://gerrit.wikimedia.org/r/1236764

Change #1236764 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [WIP] Add listIndex support for getAllRefsInReflistOrderByIndex

https://gerrit.wikimedia.org/r/1236764

awight changed the task status from Stalled to Open.Feb 18 2026, 9:12 AM
awight subscribed.

Seems ready to work on now?

Change #1250592 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/Cite@master] Render search results withouth relying on in MWReferenceSearchWidget

https://gerrit.wikimedia.org/r/1250592

Change #1236764 abandoned by WMDE-Fisch:

[mediawiki/extensions/Cite@master] [WIP] Add listIndex based methods to MWGroupReferences

Reason:

Done better in I1a592077756afb0019346cb16801f54ccfde08fc

https://gerrit.wikimedia.org/r/1236764

Change #1250592 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Render search results withouth relying on in MWReferenceSearchWidget

Reason:

I tried to rebase this. But I'm afraid there is nothing left after I6d5da7d got abandoned as well. Sorry.

https://gerrit.wikimedia.org/r/1250592

Change #1259050 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove unused filter code from ve.ui.MWReferenceSearchWidget

https://gerrit.wikimedia.org/r/1259050

Change #1259066 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Introduce ve.dm.MWReferenceKeyGenerator.extractNameFromListKey

https://gerrit.wikimedia.org/r/1259066

Change #1259070 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Various minor code cleanups in ve.ui.MWReferenceSearchWidget

https://gerrit.wikimedia.org/r/1259070

Change #1259050 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove unused filter code from ve.ui.MWReferenceSearchWidget

https://gerrit.wikimedia.org/r/1259050

WMDE-Fisch renamed this task from [Refactor] Render search results withouth relying on `mainRefKey` in MWReferenceSearchWidget to [Refactor] Show main content in the ReferenceSearchWidget of a sub-ref node without relying on a main node.Mar 24 2026, 6:00 PM
WMDE-Fisch updated the task description. (Show Details)

Change #1259066 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Introduce ve.dm.MWReferenceKeyGenerator.extractNameFromListKey

https://gerrit.wikimedia.org/r/1259066

Change #1259070 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Various minor code cleanups in ve.ui.MWReferenceSearchWidget

https://gerrit.wikimedia.org/r/1259070

Change #1261272 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add direct listIndex lookup to ve.dm.MWDocumentReferences

https://gerrit.wikimedia.org/r/1261272

Change #1261272 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add direct listIndex lookup to ve.dm.MWDocumentReferences

https://gerrit.wikimedia.org/r/1261272

Change #1248837 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [WIP] VE: Render ReferenceSearchWidget without assuming main ref nodes

https://gerrit.wikimedia.org/r/1248837

Change #1270130 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [WIP] VE: Render ReferenceSearchWidget without assuming main ref nodes

https://gerrit.wikimedia.org/r/1270130

Change #1248837 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [WIP] VE: Render ReferenceSearchWidget without assuming main ref nodes

https://gerrit.wikimedia.org/r/1248837

Change #1270131 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Build top-level refs in footnote order

https://gerrit.wikimedia.org/r/1270131

Change #1270131 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Build top-level refs in footnote order

https://gerrit.wikimedia.org/r/1270131

Change #1270937 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Push a little more code into the new MWReferenceKeyGenerator

https://gerrit.wikimedia.org/r/1270937

Change #1270937 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Push a little more code into the new MWReferenceKeyGenerator

https://gerrit.wikimedia.org/r/1270937

Change #1271882 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Consider completely empty InternalItemNodes missing content

https://gerrit.wikimedia.org/r/1271882

Change #1271882 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Consider completely empty InternalItemNodes missing content

https://gerrit.wikimedia.org/r/1271882

Change #1275805 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Assert listKey in ve.ui.MWReferenceSearchWidget test as well

https://gerrit.wikimedia.org/r/1275805

Change #1275819 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Make ve.dm.MWGroupReferences comparators static

https://gerrit.wikimedia.org/r/1275819

Change #1275805 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Assert listKey in ve.ui.MWReferenceSearchWidget test as well

https://gerrit.wikimedia.org/r/1275805

Change #1275819 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Make ve.dm.MWGroupReferences comparator static

https://gerrit.wikimedia.org/r/1275819

Change #1270130 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Render ReferenceSearchWidget without assuming main ref nodes

https://gerrit.wikimedia.org/r/1270130

Tobi_WMDE_SW claimed this task.