Page MenuHomePhabricator

[Refactor] Show main content in the ReferencesList of a sub-ref node without relying on a main node
Closed, ResolvedPublic

Description

Context

Currently the reference lists use getTopLevelKeysInReflistOrder in MWGroupReferences. MWGroupReferences builds an index for refs and subrefs using mainRefKey. That needs to change. We need to do something similar but with the mainListIndex only.

Similar to T415524: [Refactor] Show main content in the ReferenceSearchWidget of a sub-ref node without relying on a main node

Task
  • Build the search results correctly independent of main ref nodes in main+details cases
  • Make sure the main content can be seen independent of main ref nodes in main+details cases

Note that the old reference list implementation in ve.dm.MWGroupReferences has the side effect of calling setGroupIndex on every reference node, to wire footnote numbers from the reflist back into the footnote markers. If we merge the code here without reimplementing that side effect, then we'll have two separate algorithms responsible for numbering the markers vs. the reflist. It's best if we can solve this side-effect before merging the reflist change.

See also T419849: [Refactor] Reimplement group references structure without relying on synthetic ref nodes or list key

Related Objects

Event Timeline

WMDE-Fisch renamed this task from [Refactor] Rewrite any MWReferenceNode dependencies related to the ve.ce.MWReferencesListNode to [Refactor] Render reference list withouth relying on `mainRefKey` in dm/ce.MWReferencesListNode.Feb 3 2026, 3:52 PM
WMDE-Fisch updated the task description. (Show Details)
lilients_WMDE renamed this task from [Refactor] Render reference list withouth relying on `mainRefKey` in dm/ce.MWReferencesListNode to [Refactor] Render reference list without relying on `mainRefKey` in dm/ce.MWReferencesListNode.Mar 4 2026, 1:01 PM
lilients_WMDE changed the task status from Stalled to Open.

Change #1248837 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Reference list renders without assuming ref node

https://gerrit.wikimedia.org/r/1248837

awight subscribed.
WMDE-Fisch renamed this task from [Refactor] Render reference list without relying on `mainRefKey` in dm/ce.MWReferencesListNode to [Refactor] Show main content in the ReferencesList of a sub-ref node without relying on a main node.Mar 24 2026, 6:08 PM
WMDE-Fisch updated the task description. (Show Details)

Change #1248837 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [WIP] Reference list renders without assuming ref node

https://gerrit.wikimedia.org/r/1248837

Change #1248837 had a related patch set uploaded (by Awight; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [WIP] Reference list renders without assuming ref node

https://gerrit.wikimedia.org/r/1248837

awight changed the task status from Stalled to Open.Apr 14 2026, 1:44 PM
awight removed awight as the assignee of this task.

Change #1271882 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Consider completely empty InternalItemNodes missing content

https://gerrit.wikimedia.org/r/1271882

Change #1271882 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Consider completely empty InternalItemNodes missing content

https://gerrit.wikimedia.org/r/1271882

Change #1248837 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Reference list renders without assuming ref node

https://gerrit.wikimedia.org/r/1248837

Tobi_WMDE_SW claimed this task.