It was pointed out that one of instrumentation calls is missing relevant parameters defined in the instrumentation spec:
action: edit_saved action_source: EditCheck-2 page: revision_id: <rev ID of the edit that was saved> namespace_id: <ns ID of the page>
Currently, the implementation is missing the namespace and revision id, and the action is using a - instead of _ as defined.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Michael | T415580 Revise Tone instrumentation for a saved edit is missing important custom parameters | |||
| Invalid | None | T415724 Revise Tone: Remove Test wiki from experiment results |
Change #1233223 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): add missing instrumentation parameters
Change #1233236 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] fix(ReviseToneExperimentEditIngress): add missing fields and correction action name
Change #1233236 abandoned by Sergio Gimeno:
[mediawiki/extensions/GrowthExperiments@master] fix(ReviseToneExperimentEditIngress): add missing fields and correction action name
Reason:
Done in I20125a49206803467572d6bc452c941ac05dcfa2
Change #1233223 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): add missing instrumentation parameters
Change #1233709 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.12] metrics(ReviseTone): add missing instrumentation parameters
Change #1233709 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.12] metrics(ReviseTone): add missing instrumentation parameters
Mentioned in SAL (#wikimedia-operations) [2026-01-27T14:13:44Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1233709|metrics(ReviseTone): add missing instrumentation parameters (T415580)]]
Mentioned in SAL (#wikimedia-operations) [2026-01-27T14:15:53Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, migr: Backport for [[gerrit:1233709|metrics(ReviseTone): add missing instrumentation parameters (T415580)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Change #1233721 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.12] Revert "metrics(ReviseTone): add missing instrumentation parameters"
Change #1233721 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.12] Revert "metrics(ReviseTone): add missing instrumentation parameters"
Mentioned in SAL (#wikimedia-operations) [2026-01-27T14:35:19Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1233721|Revert "metrics(ReviseTone): add missing instrumentation parameters" (T415580)]]
Mentioned in SAL (#wikimedia-operations) [2026-01-27T14:37:27Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:1233721|Revert "metrics(ReviseTone): add missing instrumentation parameters" (T415580)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2026-01-27T14:44:56Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233721|Revert "metrics(ReviseTone): add missing instrumentation parameters" (T415580)]] (duration: 09m 37s)
Unfortunately, the change caused an error when deployed to wmf.12 on mwdebug and had to be reverted (logstash event, revert commit):
Non-scalar value found in the event
The message has prop_name: revision_id and prop_val_type: MediaWiki\Revision\RevisionStoreRecord set, so I think this code was missing a call to ->getId():
'revision_id' => $event->getLatestRevisionAfter(),
As the faulty commit made it into wmf.13, this is a train blocker for now. Options to unblock the train include:
@Michael et al. will continue working on this, so for now I’m leaving wmf.13 untouched and just marking this as a blocker for T413804: 1.46.0-wmf.13 deployment blockers.
Change #1233746 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): revision id must be an integer
Change #1233746 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): revision id must be an integer
Change #1233773 had a related patch set uploaded (by Brennen Bearnes; author: Michael Große):
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.13] metrics(ReviseTone): revision id must be an integer
@Michael Would a revert of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1233223 be the easier path to unblocking the train here?
Maybe, but that still would leave this experiment event recording broken, and we still would need to back-port those changes to .13 later anyway. So I see you already created the backport, is it possible to just move that forward?
So I see you already created the backport, is it possible to just move that forward?
Yeah, I can deploy https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1233773
Does that leave the train blocked on a remaining error?
No, that would unblock the train! The remaining error is confusing but much lower incidence, and it already exists in .12, so it is unrelated to the train per se.
Change #1233773 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.13] metrics(ReviseTone): revision id must be an integer
Mentioned in SAL (#wikimedia-operations) [2026-01-27T18:42:03Z] <brennen@deploy2002> Started scap sync-world: Backport for [[gerrit:1233788|SI: Provide caller for user IDs query in cases pager (T415694)]], [[gerrit:1233773|metrics(ReviseTone): revision id must be an integer (T415580)]]
Mentioned in SAL (#wikimedia-operations) [2026-01-27T18:44:11Z] <brennen@deploy2002> brennen, dreamyjazz: Backport for [[gerrit:1233788|SI: Provide caller for user IDs query in cases pager (T415694)]], [[gerrit:1233773|metrics(ReviseTone): revision id must be an integer (T415580)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Once this has been fully merged and back-ported, this task is no longer a train-blocker and should no longer be UBN. However, it should still stay open at "High" priority.
Mentioned in SAL (#wikimedia-operations) [2026-01-27T18:49:49Z] <brennen@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233788|SI: Provide caller for user IDs query in cases pager (T415694)]], [[gerrit:1233773|metrics(ReviseTone): revision id must be an integer (T415580)]] (duration: 07m 46s)
Change #1234465 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): don't submit experiment with missing data
I added a change for the "empty experiment" validation error. I still don't know why it happens.
I looked closer at the request for one of these errors and it seems to be an account creation on frwiki: https://logstash.wikimedia.org/goto/988560a254430be9bdbb571d0b0aa93b
But why would an account creation trigger an edit somewhere? And why does this seemingly only happen on frwiki/ptwiki/arwiki, but not on enwiki?
Change #1234465 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] metrics(ReviseTone): don't submit experiment with missing data
QA Note: Probably the only thing to check here is that there are no validation errors. The automatic analysis seems plausible.