Are the warnings coming from other stack traces too?

Is it worth bumping LocalisationCache::VERSION, as that does use FileDependancy too...

One useage in translatewiki config too

https://codesearch.wmcloud.org/search/?q=FileDependency&files=&excludeFiles=&repos=

In T415619#11556621, @Reedy wrote:

Are the warnings coming from other stack traces too?

I haven't noticed anything from anywhere else but quite possibly that there will be. The errors from MessageGroup cache causes the entire site to come down, so I haven't been able to test other code paths.

Is it worth bumping LocalisationCache::VERSION, as that does use FileDependancy too...

One useage in translatewiki config too

https://codesearch.wmcloud.org/search/?q=FileDependency&files=&excludeFiles=&repos=

I'll check these but I didn't see errors related to these when I briefly deployed the cache version update for the FileBasedMessageGroups. Still think its worth updating the cache versions wherever possible.

Mentioned in SAL (#wikimedia-operations) [2026-01-27T19:01:40Z] <brennen> 1.46.0-wmf.13 train status (T413804): currently blocked by T415619

I did two things:

• Marked the properties as public
• Annotated the class with #[AllowDynamicProperties]

While this stopped the warnings from appearing, it doesn't appear to map the properties to the objects properly. I get the following error:

[2026-01-27T19:05:53.928045+00:00] error.ERROR: [87376532722a976c9faebdd2] /   PHP Warning: foreach() argument must be of type array|object, null given {"exception":"[object] (ErrorException(code: 0): PHP Warning: foreach() argument must be of type array|object, null given at /srv/mediawiki/workdir/includes/Language/Dependency/DependencyWrapper.php:48)

For what it's worth, git bisecting locally (for me) also seems to suggest that this is caused by bb14bd0d50d6 / https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1228558 (for T353458). I can reproduce this without any extensions loaded AFAICS.

DependencyWrapper has no cache version, and wraps an array of CacheDependency, which can include FileDependency (among others). Which the CacheDependency implementations provide no apparent versioning either.

I wonder if this is actually a train blocker, as I'm guessing we'd see that beta/the test wikis were broken by it too

I do note similar errors on testwikis. About 700 of these (also some for $name):

Error

• service.version: 1.46.0-wmf.13
• timestamp: 2026-01-27T20:24:25.034Z
• labels.phpversion: 8.3.29
• trace.id: e7e9276b-04f1-44bd-9c1c-ab234481ee56
• Find trace.id in Logstash

[{reqId}] {exception_url}   PHP Deprecated: Creation of dynamic property MediaWiki\Language\Dependency\DependencyWrapper::$value is deprecated

Change #1233822 had a related patch set uploaded (by Reedy; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.46.0-wmf.13] FileBasedMessageGroupFactory: Update cache version

https://gerrit.wikimedia.org/r/1233822

In T415619#11556621, @Reedy wrote:

Are the warnings coming from other stack traces too?

This is a randomly selected stack trace from xdebug locally (without extensions loaded at the time of testing), in case it's useful:

PHP Stack trace:
PHP   1. {main}() /[...]/index.php:0
PHP   2. MediaWiki\MediaWikiEntryPoint->run() /[...]/index.php:44
PHP   3. MediaWiki\Actions\ActionEntryPoint->execute() /[...]/includes/MediaWikiEntryPoint.php:180
PHP   4. MediaWiki\Actions\ActionEntryPoint->performRequest() /[...]/includes/Actions/ActionEntryPoint.php:144
PHP   5. MediaWiki\Actions\ActionEntryPoint->performAction($article = [...]) /[...]/includes/Actions/ActionEntryPoint.php:510
PHP   6. MediaWiki\Actions\ViewAction->show() /[...]/includes/Actions/ActionEntryPoint.php:739
PHP   7. MediaWiki\Page\Article->view() /[...]/includes/Actions/ViewAction.php:71
PHP   8. MediaWiki\Page\Article->showProtectionIndicator() /[...]/includes/Page/Article.php:476
PHP   9. MediaWiki\Title\Title->isMainPage() /[...]/includes/Page/Article.php:595
PHP  10. MediaWiki\Title\Title::newMainPage($localizer = *uninitialized*) /[...]/includes/Title/Title.php:1380
PHP  11. MediaWiki\Message\Message->text() /[...]/includes/Title/Title.php:685
PHP  12. MediaWiki\Message\Message->format($format = 'text') /[...]/includes/Language/Message/Message.php:1136
PHP  13. MediaWiki\Message\Message->fetchMessage() /[...]/includes/Language/Message/Message.php:1034
PHP  14. MediaWiki\Language\MessageCache->get($key = 'mainpage', $useDB = TRUE, $language = 'en', $info = class MediaWiki\Language\MessageInfo { public ?string $usedKey = 'mainpage'; public ?string $langCode = NULL }) /[...]/includes/Language/Message/Message.php:1534
PHP  15. MediaWiki\Language\MessageCache->getMessageFromFallbackChain($code = 'en', $lckey = 'mainpage', $useDB = TRUE, $info = class MediaWiki\Language\MessageInfo { public ?string $usedKey = 'mainpage'; public ?string $langCode = NULL }) /[...]/includes/Language/MessageCache.php:1031
PHP  16. MediaWiki\Language\MessageCache->getMessageForLang($langCode = 'en', $lckey = 'mainpage', $useDB = TRUE, $alreadyTried = [], $info = class MediaWiki\Language\MessageInfo { public ?string $usedKey = 'mainpage'; public ?string $langCode = NULL }) /[...]/includes/Language/MessageCache.php:1138
PHP  17. MediaWiki\Language\MessageCache->getMsgFromNamespace($title = 'Mainpage', $code = 'en') /[...]/includes/Language/MessageCache.php:1165
PHP  18. MediaWiki\Language\MessageCache->isMainCacheable($name = 'Mainpage', $code = 'en') /[...]/includes/Language/MessageCache.php:1299
PHP  19. MediaWiki\Language\LocalisationCache->getSubitem($code = 'en', $key = 'messages', $subkey = 'mainpage') /[...]/includes/Language/MessageCache.php:674
PHP  20. MediaWiki\Language\LocalisationCache->loadSubitem($code = 'en', $key = 'messages', $subkey = 'mainpage') /[...]/includes/Language/LocalisationCache.php:422
PHP  21. MediaWiki\Language\LocalisationCache->initLanguage($langCode = 'en') /[...]/includes/Language/LocalisationCache.php:583
PHP  22. MediaWiki\Language\LocalisationCache->isExpired($code = 'en') /[...]/includes/Language/LocalisationCache.php:673
PHP  23. MediaWiki\Language\LocalisationCache->getFromStore($code = 'en', $key = 'deps') /[...]/includes/Language/LocalisationCache.php:626
PHP  24. MediaWiki\Language\LCStoreDB->get($code = 'en', $key = 'deps') /[...]/includes/Language/LocalisationCache.php:549
PHP  25. unserialize($data = 'a:21:{i:0;O:14:"FileDependency":2:{s:24:"\000FileDependency\000filename";s:108:"/[...]/languages/messages/MessagesEn.php";s:25:"\000FileDependency\000timestamp";i:1769544629;}i:1;O:14:"FileDependency":2:{s:24:"\000FileDependency\000filename";s:101:"/[...]/languages/data/plurals.xml";s:25:"\000FileDependency\000timestamp";i:1761638637;}i:2;O:14:"FileDependency":2:{s:24:"\000FileDependency\000filename";s:'...) /[...]/includes/Language/LCStoreDB.php:60
PHP Deprecated:  Creation of dynamic property MediaWiki\Language\Dependency\ConstantDependency::$name is deprecated in /[...]/includes/Language/LCStoreDB.php on line 60

LocalisationCache::VERSION hasn't been changed in nearly 3 years...

That one wouldn't be seen in WMF production as we use CDB we build per MW version. For example, in the json blob it's using the new NS - "deps":"a:490:{i:0;O:44:\"MediaWiki\\Language\\Dependency\\FileDependency\":2:{s:54:\"\u0000MediaWiki\\Language\\Dependency\\FileDependency\u0000filename\";s:74:

Change #1233822 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.46.0-wmf.13] FileBasedMessageGroupFactory: Update cache version

https://gerrit.wikimedia.org/r/1233822

Mentioned in SAL (#wikimedia-operations) [2026-01-27T21:25:22Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1233822|FileBasedMessageGroupFactory: Update cache version (T415619)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-27T21:27:45Z] <cjming@deploy2002> cjming, reedy: Backport for [[gerrit:1233822|FileBasedMessageGroupFactory: Update cache version (T415619)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-27T21:33:46Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233822|FileBasedMessageGroupFactory: Update cache version (T415619)]] (duration: 08m 24s)

Error

• mwversion: 1.46.0-wmf.13
• timestamp: 2026-01-27T21:20:55.452Z
• phpversion: 8.3.29
• reqId: af5c6004-5deb-4b44-8b8e-efd23a1346e3
• Find reqId in Logstash

[{reqId}] {exception_url}   PHP Warning: foreach() argument must be of type array|object, null given

Impact

Notes

Error

• mwversion: 1.46.0-wmf.13
• timestamp: 2026-01-27T21:39:22.583Z
• phpversion: 8.3.29
• reqId: e2a164b5-8378-46b5-a15f-5be1f1bdbbcf
• Find reqId in Logstash

[{reqId}] {exception_url}   TypeError: MediaWiki\Extension\Translate\MessageGroupConfiguration\HookDefinedMessageGroupFactory::appendAutoloader(): Argument #1 ($additions) must be of type array, null given, called in /srv/mediawiki/php-1.46.0-wmf.13/exten

Impact

Notes

After some discussion in #wikimedia-operations and looking at error rates, I'm going to see what this looks like on group0.

After some discussion in #wikimedia-operations and looking at error rates, I'm going to see what this looks like on group0.

The answer here is that this is definitely a blocker.

Change #1233861 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Revert "Language: Namespace dependency classes"

https://gerrit.wikimedia.org/r/1233861

Change #1233862 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.46.0-wmf.13] Revert "Language: Namespace dependency classes"

https://gerrit.wikimedia.org/r/1233862

Let's just revert for now.

Change #1233862 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.13] Revert "Language: Namespace dependency classes"

https://gerrit.wikimedia.org/r/1233862

Mentioned in SAL (#wikimedia-operations) [2026-01-27T23:38:01Z] <reedy@deploy2002> Started scap sync-world: Backport for [[gerrit:1233860|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]], [[gerrit:1233862|Revert "Language: Namespace dependency classes" (T415619)]], [[gerrit:1233858|build: Upgrade PHPUnit from 10.5.59 to 10.5.62 to unblock CI (T415723)]], [[gerrit:1233859|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-28T00:02:33Z] <reedy@deploy2002> jforrester, reedy, zabe: Backport for [[gerrit:1233860|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]], [[gerrit:1233862|Revert "Language: Namespace dependency classes" (T415619)]], [[gerrit:1233858|build: Upgrade PHPUnit from 10.5.59 to 10.5.62 to unblock CI (T415723)]], [[gerrit:1233859|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]] synced to the testservers (see https://wikite

Mentioned in SAL (#wikimedia-operations) [2026-01-28T00:15:11Z] <reedy@deploy2002> Finished scap sync-world: Backport for [[gerrit:1233860|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]], [[gerrit:1233862|Revert "Language: Namespace dependency classes" (T415619)]], [[gerrit:1233858|build: Upgrade PHPUnit from 10.5.59 to 10.5.62 to unblock CI (T415723)]], [[gerrit:1233859|Updated phpunit/phpunit from 9.6.21 to 9.6.33 (T415723)]] (duration: 37m 10s)

Probably related:

Error

• mwversion: 1.46.0-wmf.12
• timestamp: 2026-01-28T00:21:09.697Z
• phpversion: 8.3.29
• reqId: 4269d1b8-eac4-4fb5-b5f1-29cdc1968c7d
• Find reqId in Logstash

[{reqId}] {exception_url}   TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given, called in /srv/mediawiki/php-1.46.0-wmf.12/includes/libs/ObjectCache/WANObjectCache.php on line 649

Probably related

Yeah. Filed as T415725.

Change #1233861 merged by jenkins-bot:

[mediawiki/core@master] Revert "Language: Namespace dependency classes"

https://gerrit.wikimedia.org/r/1233861

After deploying the revert, I had to restart memcache to stop the TypeErrors. Without it I was getting the error highlighted by @Catrope in https://phabricator.wikimedia.org/T415619#11560759