Page MenuHomePhabricator

Intacct - changes requested by Tiffany
Closed, ResolvedPublic

Description

  1. group by account code, not channel
  2. change description for batch & rows around date

Item 1 - There seem to be too many lines in the journal entries. We’ve noticed some where the date range, GL, department, funding, entity, currency, PSP, and activity type, date range are the same, but there are multiple lines split. One example you can check is CREV journal entry 120 in the sandbox. (edited)
2:27
Item 2 - Some journal entry lines seem to have incorrect date ranges. One example you can check is CREV journal entry 167 in the sandbox. Julie checked the donations for the journal entry, and both of the donations are from January 15, but the date range begins with December 2. We wanted to propose that PayPal can just have a single date (the day they settled). The intention of the memo date range was to provide the PSP’s batch settlement date range when we were planning weekly file transfers.
2:28
Request - We’d like to have the description on the batch journal entry changed a bit. Currently you are entering it as currency code, net amount, “Contribution Revenue”, batch date range. We would like to request: PSP name, currency code, “Contribution Revenue”, batch date range (remove the net amount and add the PSP). So for example this is what we would like:
Adyen EUR Contribution Revenue 12/31/2025 - 01/02/2026
Eileen McNaughton

Today at 4:40 PM

Thanks Tiffany

  • yeah these are ones with different channels but the same account code - I can squash them

Thanks - just using the settlement date is good
Sure - I can get rid of the batch amount - I was including it in there because it made it really easy to eyeball what was settled in the bank was what was in the batch - but I'll get rid of it. Regarding the date range though - what is it a range of? Each batch has transactions that all settled to us on the same date. However, the received date could be over a period of months. We do have the date settled to the processor but I'm wondering if using that is adding more than just the date it settled to us - cos I'm not loving the settled-to-processor-date data that we are getting (either in the processor reconciliation report or in the re-formatted version of the same) - so unless the range adds clear value I wonder if the same settlement date as in 2 is good?
4:41
Oh I just re-read - you want a single date for Paypal & a range for Adyen. Note that Braintree, Dlocal are also being batched by daily account movement - so it would be only Adyen that would potentially get a range
Eileen McNaughton

Today at 4:55 PM

also we did talk about moving Adyen to daily? (note that is a configuration option within Adyen console that would need to be changed)

And from me

  1. process valid batches regardless of the presence of invalid ones - I think that now they are not wanting a single file for SFTP we can do this.
  2. maybe store the remote batch url?

Event Timeline

Change #1236480 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Update batch status as we validate

https://gerrit.wikimedia.org/r/1236480

Change #1236480 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update batch status as we validate

https://gerrit.wikimedia.org/r/1236480

Change #1239548 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Use property for batches (to support further refactor)

https://gerrit.wikimedia.org/r/1239548

Change #1239549 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Extract getBatchSQL

https://gerrit.wikimedia.org/r/1239549

Change #1239548 merged by Eileen:

[wikimedia/fundraising/crm@master] Use property for batches (to support further refactor)

https://gerrit.wikimedia.org/r/1239548

Change #1239549 merged by Eileen:

[wikimedia/fundraising/crm@master] Extract getBatchSQL

https://gerrit.wikimedia.org/r/1239549

Change #1239771 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move status check into getBatches()

https://gerrit.wikimedia.org/r/1239771

Change #1239782 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Update batch memo and description per requirements

https://gerrit.wikimedia.org/r/1239782

Change #1239787 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move setting of sql to getRenderedSQL

https://gerrit.wikimedia.org/r/1239787

Change #1239808 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move LINE_NO calc to getJournalRows

https://gerrit.wikimedia.org/r/1239808

Change #1239771 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move status check into getBatches()

https://gerrit.wikimedia.org/r/1239771

Change #1239782 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update batch memo and description per requirements

https://gerrit.wikimedia.org/r/1239782

Change #1239787 merged by Eileen:

[wikimedia/fundraising/crm@master] Move setting of sql to getRenderedSQL

https://gerrit.wikimedia.org/r/1239787

Change #1239815 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove journal file from email

https://gerrit.wikimedia.org/r/1239815

Change #1239808 merged by Eileen:

[wikimedia/fundraising/crm@master] Move LINE_NO calc to getJournalRows

https://gerrit.wikimedia.org/r/1239808

Change #1240035 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Adjust batch description per finance request

https://gerrit.wikimedia.org/r/1240035

Change #1240037 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix inconsistent capitalisation

https://gerrit.wikimedia.org/r/1240037

Change #1240058 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Unset (& hence close) csv writers after use

https://gerrit.wikimedia.org/r/1240058

Change #1239815 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove journal file from email

https://gerrit.wikimedia.org/r/1239815

Change #1240035 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Adjust batch description per finance request

https://gerrit.wikimedia.org/r/1240035

Change #1240037 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix inconsistent capitalisation

https://gerrit.wikimedia.org/r/1240037

Change #1240058 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Unset (& hence close) csv writers after use

https://gerrit.wikimedia.org/r/1240058

Change #1247192 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add new api action FinanceIntegration.ping to test connection

https://gerrit.wikimedia.org/r/1247192

Change #1247192 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add new api action FinanceIntegration.ping to test connection

https://gerrit.wikimedia.org/r/1247192

Change #1250769 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Generate to->endowment journals

https://gerrit.wikimedia.org/r/1250769

Change #1250769 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Generate to->endowment journals

https://gerrit.wikimedia.org/r/1250769

Change #1253713 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Put back memo suffix for endowment

https://gerrit.wikimedia.org/r/1253713

Change #1253713 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Put back memo suffix for endowment

https://gerrit.wikimedia.org/r/1253713

Change #1255913 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Include Project in intacct push

https://gerrit.wikimedia.org/r/1255913

I've been putting up all sorts against this but I think it's time to merge one last patch - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1255913?usp=dashboard
and put this in Done & create new specific tasks

Change #1255913 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Include Project in intacct push

https://gerrit.wikimedia.org/r/1255913

XenoRyet set Final Story Points to 4.