Currently PCSis serving 500px, 750px, and 1000px which will be blocked/rate limited
See example: https://en.wikipedia.org/api/rest_v1/page/media-list/Cat
Currently PCSis serving 500px, 750px, and 1000px which will be blocked/rate limited
See example: https://en.wikipedia.org/api/rest_v1/page/media-list/Cat
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| common thumbnnail sizes: Pick closest candidate | mediawiki/services/mobileapps | master | +94 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | MatthewVernon | T414805 FY 25/26 WE 5.4.10 Standard Thumbnail Sizes Only | |||
| Open | None | T402792 Consider rate limiting non-standard thumbnail sizes | |||
| Resolved | Jgiannelos | T415792 Make PCS respect standard sizes |
I have a WIP patch here:
https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/+/1234441
The problem is that even though mobile-html output fixes up the thum sizes to the common thumbnail sizes, for media list we do the following:
My proposal is to just find the closest available common size and fixup with that value instead.
There are 2 questions though related to apps (cc @Tsevener @Dbrant)
Change #1234441 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):
[mediawiki/services/mobileapps@master] common thumbnnail sizes: Pick closest candidate
Something to consider: You can get rid of 1.5x IMHO. It is removed from mediawiki from what I'm seeing. One less thing to adjust.
I confirmed with @Krinkle that 1.5x has should be removed (as much as possible). It would be much better if that code path would use our API for building thumb url. Example: https://commons.wikimedia.org/w/api.php?action=query&titles=File:Albert%20Einstein%20Head.jpg&prop=imageinfo&iiurlwidth=100&iiprop=url (that also has 2x and 1.5x url too even).
Change #1234441 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] common thumbnnail sizes: Pick closest candidate