Page MenuHomePhabricator

Suggestions: Evaluate using custom icons
Open, Needs TriagePublic

Description

In T404604#11564456, we decided to use a unified icon – 💡 – to represent all Edit Suggestions.

This task involves the work of evaluating using custom icons that more directly map to/reinforce the meaning of a given Edit Check/Suggestion.

image.png (2×6 px, 1 MB)
Op.1: Unified icon for all suggestions (current solution decided in T404604)
image.png (2×6 px, 1 MB)
Op.2: Custom icons for suggestions/categories

Considerations

  • Edit Checks use the warning icon to represent the urgency. So in case we decide to use custom icons, the icons in Checks should represent the status warning instead showing the custom icon.

Story

As someone who is browsing multiple Suggestions, relatively quickly and/or in a collapsed state, I'd value them being visually distinguished so that I can decide which Suggestion(s) to pursue.

Open questions

  • Should we use a different icon for each suggestion type? Or should we use one icon per suggestion's category (e.g. links, grammar)

Requirements

Check/SuggestionCurrent iconDesired icon

Acceptance criteria (or Done)

  • Design explorations:
    • All available Checks/Suggestions are catalogued, along with the icons used within each
    • A "Desired icon" is defined for each Check/Suggestion in the catalogue as well as a broader framework we can use to define icons for Checks/Suggestions we've yet to define or implement
  •  Conduct A/B testing to see if the suggestions are clearer using unified or custom icons
  •  Implement decided solution (if needed)