Page MenuHomePhabricator

Mark pages that self-transclude as vary-revision so they are not outdated
Closed, ResolvedPublic

Description

Its common on templates to transclude themselves as an example in the "noinclude" section.

Of course this self-transclusion uses the previous version of the template, because the template page isn't inserted in the db yet at render time on page-save.

We should mark such pages as "Vary-revision" so that such pages render correctly without requiring a manual purge.

(This of course won't really help circular dependencies, but those aren't common, and you can't fix everything).

Assigning to self as I eventually plan to do this at some point, and this bug is meant as a reminder since I usually forget things I plan to do. However if someone's bored and wants to do this themselves, don't hesitate to fix the bug.


Version: 1.20.x
Severity: normal

Details

Reference
bz39590

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz39590.
Bawolff created this task.Aug 23 2012, 5:23 PM

bawolff: Still working on this? If not feel free to reset the assignee.

Wow. Totally forgot I was assigned for this. I am going to try to work on this tomorrow

gerrit change Idfac13de

Merged! Thanks Brian, and Andre.