Page MenuHomePhabricator

Allow limited editing of Patch Demo wikis
Closed, ResolvedPublic8 Estimated Story Points

Description

Current workflow:

  • Make a patch
  • Create a patch demo wiki with that patch (2 mins)
  • Repeat until finished (5-10 mins)
    • Share it
    • Get feedback
    • Update your patch
    • Edit your patch demo wiki to update the patch

For trivial changes (e.g., make that button blue) 5-10 mins is a long loop (especially if the feedback following the loop is, e.g., maybe back that button green :))

Allowing limited, non-persistent editing of short-lived Patch Demo wikis could help and may be trivial with a small enough scope.

A.C.

  • I'm able to make edits to the files in my wiki remotely without updating my patch
  • Only wiki creator should be able to edit their wiki
  • For this task:
    • edits do not need to persist following k8s events (e.g., scaling, eviction, etc)
    • does not need to be compatible with IDEs, necessarily or accept local edits (e.g., editing in a textbox is fine)
    • git operations don't have to work; e.g., getting a patch of what's been edited
  • Only MediaWiki PHP/JS/CSS files may be edited, compilation changing dependencies/extensions, getting a shell—bonus points but unnecessary
  • We should think about how to prevent folks from easily messing with AbuseFilter settings—currently we strip the user agent and the ip address before it gets to MediaWiki. But we've also turned off other javascripty AbuseFilter features in our LocalSettings.
    • Patch Demo is running code that is somewhat trusted (does require V+2) so making it hard to collect this data by accident is what we want
    • Post-config-edit linting/alerting could help here

Details

Other Assignee
dancy
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
add missing `values.schema.json` propertiesrepos/test-platform/catalyst/ci-charts!123jnucheT415922main
Allow specified users to edit code in demorepos/test-platform/catalyst/patchdemo!273jhuneidiT415922main
Add code-serverrepos/test-platform/catalyst/ci-charts!118jhuneidiT415922-2main
catalyst-code-server: repair entrypointrepos/releng/dev-images!90jhuneidiT415922-2main
Allow specified users to edit code in demorepos/test-platform/catalyst/patchdemo!264jhuneidiT415922main
Add catalyst-code-serverrepos/releng/dev-images!88jhuneidiT415922main
Customize query in GitLab

Event Timeline

thcipriani updated Other Assignee, added: dancy.
thcipriani moved this task from Backlog to Ready on the Catalyst (Luka Ijo Pimeja Jan) board.
thcipriani set the point value for this task to 8.

Tentatively assigning for some experimentation for how this could work. There are a lot of possibilities so let's try to winnow the possibilities down.

The WIP patch is a neat demo of how this could fit together and a small change (after much documentation reading) it Just Worked™.

Let's keep going to get a PoC working and put it behind a feature flag for now.

Left to do:

  • container for the code instance
  • user permission on the code instance/volume
  • password/auth protections for code instance
  • hooking this all up to the front-end
  • resource usage estimates

Mentioned in SAL (#wikimedia-releng) [2026-02-18T06:58:11Z] <jeena> Updating development images on contint primary for T415922

Mentioned in SAL (#wikimedia-releng) [2026-02-18T20:17:36Z] <jeena> Updating development images on contint primary for T415922

This is working behind a feature flag at the moment, we'll make some followups. Nice work, @jeena !