Page MenuHomePhabricator
Create Task
Maniphest T415976

Add support for urwikisource to Pywikibot
Closed, ResolvedPublic
Actions

Description

Per https://wikitech.wikimedia.org/wiki/Add_a_wiki once the wiki has been created

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
L10N: Add support for urwikisource to Pywikibotpywikibot/coremaster+3 -3
L10N: Add support for urwikisource to Pywikibotpywikibot/coremaster+11 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jan 30 2026, 4:10 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 30 2026, 4:10 AM
Pppery renamed this task from Add support for {{{language_code}}}wikisource to Pywikibot to Add support for urwikisource to Pywikibot.Jan 30 2026, 4:32 AM
Xqt added a project: good first task.Feb 5 2026, 11:30 AM
Xqt subscribed.

good first task
addwikis script can be used to add the wiki easily. The patch will be submitted after the wiki is really created.

Restricted Application added a comment. · View Herald TranscriptFeb 5 2026, 11:30 AM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Xqt triaged this task as Low priority.Feb 5 2026, 11:34 AM
Xqt mentioned this in T416116: -graph option of interwiki is not documented.Feb 5 2026, 11:41 AM
Roshani005 subscribed.Feb 5 2026, 12:47 PM

Hi! I’m a newcomer and I’d love to work on this task.
Could you please confirm if I can take it and guide me on where to start in the Pywikibot codebase?

Xqt assigned this task to NAGAM_SURYA_NARAYANA.Feb 5 2026, 1:05 PM

Hi @Roshani005, NAGAM_SURYA_NARAYANA has already announced in T416116 to work on this but you can work on T414239 which is quite similar.

NAGAM_SURYA_NARAYANA added a comment.Thu, Feb 5, 4:31 PM

Hi @Xqt
Patch uploaded: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1237260
Awaiting feedback.

Xqt added a comment.Thu, Feb 5, 4:48 PM
In T415976#11588288, @NAGAM_SURYA_NARAYANA wrote:

Hi @Xqt
Awaiting feedback.

Hm, first refer the commit message guidlines. The subject line should explain the changes and it can be the same as this task here. pre-commit formatting is not relevant - it is just a helper script. And there is no fix but only the familie file get a new site. So the commit msg should be like:

L10N: Add support for urwikisource to Pywikibot

Bug: T415976

Your pathc is not created by the addwikis tool. You shoul use it because the tool takes care of the alignments and line limits. Otherwise you have to do it by hand. Please revert your change locally and start the addwikis tool. Refer the documentation for its usage here. Refer the first example.

run python pwb.py addwikis -family:wikisource ur should do the job. Or for Windows users: py -3.13 -m pwb addwikis -family:wikisource ur where -3.13 is your installed Python version.

anoexpected mentioned this in T416566: Add support for BaseException.add_notes method for older Pythons.Fri, Feb 6, 8:33 AM
Xqt added a comment.Fri, Feb 6, 11:00 AM

@NAGAM_SURYA_NARAYANA: your patch is not completed and this task is still an issue. If you run addwikis locally, it compares the local file, not the repository. Pleas adjust the lines of your commit. Or restet you local changes and run the addwikis script.

Xqt mentioned this in T416145: Use type hints to validate user configuration variables.Fri, Feb 6, 11:04 AM
NAGAM_SURYA_NARAYANA added a comment.Fri, Feb 6, 1:39 PM

Hi @Xqt,
I reset my local repository to origin/master and re-ran the addwikis script.
The script reports that ur is already present in Family.codes and there is no remaining diff.
It looks like the change has landed upstream. Please let me know if anything further is needed from my side for T415976.

Xqt removed NAGAM_SURYA_NARAYANA as the assignee of this task.Fri, Feb 6, 1:52 PM
Xqt added a subscriber: NAGAM_SURYA_NARAYANA.
In T415976#11588288, @NAGAM_SURYA_NARAYANA wrote:

Hi @Xqt,

Thanks for checking.

I reverted my local changes for T415976 and ran the addwikis tool as suggested:
python pwb.py addwikis -family:wikisource ur

The tool reports that 'ur' is already present in the wikisource family and that
there are no wikis to add, so it does not generate any changes.

I am not actively working on T415976 anymore. Please let me know if you would
like me to take any further action there, or if the task can be considered
complete from my side.

Hi @NAGAM_SURYA_NARAYANA, please use the related task for communication. It is difficult if threads are spreaded over several tasks.

Your patch didn't solve this issue, neither the commit message was appopriate nor the family file was updated in the right format even the site code was added.

The site code was added propertly within the family file. This is the reason why addwikis reported there are no codes to add.

You could solve this issue in two ways (beside the commit message thing:

  • reset your local repository the remote master; run the addwikis script, upload the change - or
  • update your local repository in that way that the codes have a line break after 'vi', and not before 'ur', and submitt it.

The remote master doesn't have the 'ur' code, see here.

I am removing you from assignment. You may add yourself again if you want to work on it.

gerritbot added a comment.Fri, Feb 6, 2:19 PM

Change #1237496 had a related patch set uploaded (by NAGAM SURYA NARAYANA; author: Xqt):

[pywikibot/core@master] L10N: Add support for urwikisource to Pywikibot

https://gerrit.wikimedia.org/r/1237496

gerritbot added a project: Patch-For-Review.Fri, Feb 6, 2:19 PM
NAGAM_SURYA_NARAYANA added a comment.Fri, Feb 6, 2:34 PM

Hi @Xqt,

Thank you for the clarification and for your patience.

I now understand the issue clearly:

  • My earlier patch added ur in an incorrect alignment.
  • Because of that, addwikis compared against my local file and reported no changes.
  • The upstream master still does not contain ur in the correct position.

I have reset my local repository to origin/master, re-ran the addwikis script, and verified the correct diff where the line break is after vi (not before ur).

I have submitted a new change with:

  • Proper formatting generated by addwikis
  • Correct commit message following the guidelines

Link to the new Gerrit change:
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1237496

Please let me know if this now matches the expected result, or if any further adjustment is required.
Thanks again for your guidance.

Xqt assigned this task to NAGAM_SURYA_NARAYANA.Fri, Feb 6, 2:34 PM

@NAGAM_SURYA_NARAYANA, Great, the family is well, thank you. But the addwikis part is not related to this task, probably added by accident due to a new release from source. Could you remove it please.

NAGAM_SURYA_NARAYANA added a comment.Fri, Feb 6, 3:27 PM

Hi @Xqt,

Thanks for pointing that out. I’ve reverted the unintended change to scripts/maintenance/addwikis.py.
git diff is now clean, and only the wikisource family change remains.

Please let me know if everything looks good now.

Xqt added a comment.Sat, Feb 7, 6:38 AM

You have to upload your change. There is just PS1.

gerritbot added a comment.Sat, Feb 7, 2:25 PM

Change #1237628 had a related patch set uploaded (by NAGAM SURYA NARAYANA; author: NAGAM SURYA NARAYANA):

[pywikibot/core@master] L10N: Add support for urwikisource to Pywikibot

https://gerrit.wikimedia.org/r/1237628

NAGAM_SURYA_NARAYANA added a comment.Sat, Feb 7, 2:29 PM

Hi @Xqt,
I’ve uploaded the updated change with a new patchset here:
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1237628

The change now contains only the wikisource family update, with correct formatting and no addwikis changes.
Please let me know if anything else is needed. Thanks!

gerritbot added a comment.Sat, Feb 7, 2:41 PM

Change #1237496 abandoned by Xqt:

[pywikibot/core@master] L10N: Add support for urwikisource to Pywikibot

Reason:

New PS with https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1237628

https://gerrit.wikimedia.org/r/1237496

Xqt changed the task status from Open to Stalled.Sat, Feb 7, 2:43 PM
Xqt edited parent tasks, added: T415960: Create Wikisource Urdu; removed: T415974: Post-creation work for urwikisource.

Waiting for wiki is created.

NAGAM_SURYA_NARAYANA added a comment.Mon, Feb 9, 11:29 AM

Hi @Xqt,
Just checking in on this task. I understand it is waiting for the creation of Urdu Wikisource.
Please let me know if there is anything I can help with from my side or if any changes are needed in my patch.

Also let me know shall I work on any other beginner friendly task.

Thanks!

Zabe changed the task status from Stalled to Open.Fri, Mar 6, 2:29 AM
gerritbot added a comment.Fri, Mar 6, 2:40 AM

Change #1237628 merged by jenkins-bot:

[pywikibot/core@master] L10N: Add support for urwikisource to Pywikibot

https://gerrit.wikimedia.org/r/1237628

Maintenance_bot removed a project: Patch-For-Review.Fri, Mar 6, 3:31 AM
Xqt closed this task as Resolved.Fri, Mar 6, 7:32 AM
Xqt mentioned this in T418994: Publish Pywikibot 11.1.Fri, Mar 6, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits