Page MenuHomePhabricator

DR should be able to add double opt in activities
Closed, ResolvedPublic

Description

Unfortunately, we are checking for the contact having added the activity themselves, so we would have to change to checking for with that contact (and backfill existing). Also need to update activity type so it is selectable to add in UI.

Event Timeline

Change #1236771 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Set target_contact_id on Double Opt-In activities

https://gerrit.wikimedia.org/r/1236771

Change #1236793 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Only get target contacts for double opt in activities

https://gerrit.wikimedia.org/r/1236793

Change #1236793 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Only get target contacts for double opt in activities

https://gerrit.wikimedia.org/r/1236793

Change #1236796 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Add target contact to existing double opt in activities

https://gerrit.wikimedia.org/r/1236796

Change #1236800 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Add target contact when creating double opt in activities

https://gerrit.wikimedia.org/r/1236800

Change #1236800 abandoned by Lars SG:

[wikimedia/fundraising/crm@master] Add target contact when creating double opt in activities

https://gerrit.wikimedia.org/r/1236800

Change #1236796 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add target contact to existing double opt in activities

https://gerrit.wikimedia.org/r/1236796

Change #1236771 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Set target_contact_id on Double Opt-In activities

https://gerrit.wikimedia.org/r/1236771

Change #1237353 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Only count double opt in if activity is for correct email

https://gerrit.wikimedia.org/r/1237353

Change #1237353 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Only count double opt in if activity is for correct email

https://gerrit.wikimedia.org/r/1237353

Still TODO on this task: UI hook to pre-fill primary email address in subject and select 'completed' activity status

Change #1239402 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Pre-fill status and subject when adding Double Opt-In

https://gerrit.wikimedia.org/r/1239402

Change #1239402 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Pre-fill subject when adding Double Opt-In

https://gerrit.wikimedia.org/r/1239402

Ejegg set the point value for this task to 2.
Ejegg set Final Story Points to 2.
Ejegg removed the point value 2 for this task.
Ejegg removed Final Story Points.
XenoRyet set Final Story Points to 2.

Hi @Ejegg, is the DR now able to update the double opt-in activities? If so, could you pls share the process? Ty!

@SHust I'm just following up with legal on the exact details of when we can record a double opt in manually and what we would need to record specifically — and I'll let you know once we have those details.

Hi @SHust once the legal issues are sorted, here's the technical way to do it: you just go to the activities tab for the contact, click New Activity, then search for 'double' to select 'Double Opt-In'. On the new activity form, the 'subject' field should default to the primary email for the contact. This is what we're using in the backend to determine which email address is opted in.

image.png (282×545 px, 25 KB)

Thanks for the updates, guys! We'll wait to hear about the legal sorting before sharing this info with the team.