Page MenuHomePhabricator

Special:Log does not allow switching to a different log type when an incompatible field option is specified
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The "Type of move" field does not support "block" as a value, so the error message "The value you specified is not a valid option." is shown, and no log entries are displayed.

What should have happened instead?:

  • When the page is displayed as a result of a form submission, it should reset incompatible field values so that log entries for the newly selected log type are shown correctly.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

  • N/A

Other information (browser name/version, screenshots, etc.):

T416084.PNG (915×660 px, 22 KB)

Event Timeline

My proposed patch for T320871: Special:Log should show action combo box when switching log types happens to fix this issue (since it effectively creates separate subtype fields for every log type, instead of having one field that has different allowed values depending on the log type).

I've had a hard time getting people to review it, though, so if anyone wants to propose a smaller patch for just this bug, I'd be happy to review that.

Change #1183189 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Display extra form fields dynamically on Special:Log

https://gerrit.wikimedia.org/r/1183189

Change #1183189 merged by jenkins-bot:

[mediawiki/core@master] Display extra form fields dynamically on Special:Log

https://gerrit.wikimedia.org/r/1183189

matmarex claimed this task.