Page MenuHomePhabricator
Create Task
Maniphest T416220

On New Topic focus is set to content field
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to talk page
  • Click button to add new topic

What happens?:
Form focus is moved to textarea

What should have happened instead?:
Form focus should be moved to topic title first

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
CodeMirror: restore focus when deactivatingBhsdmediawiki/extensions/CodeMirrormaster+9 -4
CodeMirrorVisualEditor: conditionally restore focus during deactivationMusikAnimalmediawiki/extensions/CodeMirrormaster+21 -12
CodeMirror: restore focus for VE during initialization, as appropriateMusikAnimalmediawiki/extensions/CodeMirrormaster+19 -4
Customize query in gerrit

Related Objects

Event Timeline

Wargo created this task.Feb 2 2026, 5:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2026, 5:46 PM
Esanders subscribed.Feb 2 2026, 5:54 PM

I can't reproduce this. The subject field is focused for me.

Wargo added a project: MediaWiki-extensions-CodeMirror.Feb 3 2026, 10:48 PM

Now I know this happens when CodeMirror is enabled.

Bhsd moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.Feb 4 2026, 1:21 AM
Bhsd subscribed.Feb 27 2026, 2:27 AM

I cannot reproduce this with CodeMirror enabled.

MusikAnimal claimed this task.Mar 3 2026, 7:30 PM
MusikAnimal subscribed.

I am able to repro, and seems to be caused by codemirror.visualEditor.js#162. Note the behaviour only happens on initialization, so if you i.e. use the reply tool then try "Add topic", it works fine as-is.

This behaviour is desirable for normal 2017 editor uses, but not with DiscussionTools "Add topic".

gerritbot added a comment.Mar 3 2026, 7:32 PM

Change #1247666 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorVisualEditor: disable autofocus for DiscussionTools' add topic

https://gerrit.wikimedia.org/r/1247666

gerritbot added a project: Patch-For-Review.Mar 3 2026, 7:32 PM
MusikAnimal changed the task status from Open to In Progress.Mar 3 2026, 7:32 PM
MusikAnimal added a comment.EditedMar 3 2026, 9:56 PM

Related: The auto-focus takes effect in any arbitrary use of VE + CM, such as https://meta.wikimedia.org/wiki/Special:WishlistIntake . The above patch is a quick fix for DT but I'm thinking we need a config option or something to tell CodeMirror that a VE surface should not be auto-focused. I'll look into a follow-up patch for that.

MusikAnimal added a comment.Mar 4 2026, 9:58 PM
In T416220#11670919, @MusikAnimal wrote:

Related: The auto-focus takes effect in any arbitrary use of VE + CM, such as https://meta.wikimedia.org/wiki/Special:WishlistIntake . The above patch is a quick fix for DT but I'm thinking we need a config option or something to tell CodeMirror that a VE surface should not be auto-focused. I'll look into a follow-up patch for that.

This should now be fixed, too, in PS3 of r1247666.

gerritbot added a comment.Mar 6 2026, 4:33 PM

Change #1247666 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: restore focus for VE during initialization, as appropriate

https://gerrit.wikimedia.org/r/1247666

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 6 2026, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 6 2026, 5:31 PM
gerritbot added a comment.Mar 10 2026, 8:22 PM

Change #1250069 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorVisualEditor: conditionally restore focus during deactivation

https://gerrit.wikimedia.org/r/1250069

gerritbot added a project: Patch-For-Review.Mar 10 2026, 8:22 PM
gerritbot added a comment.Mar 11 2026, 11:23 PM

Change #1250069 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorVisualEditor: conditionally restore focus during deactivation

https://gerrit.wikimedia.org/r/1250069

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2026, 11:31 PM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 12 2026, 12:00 AM
Bhsd closed this task as Resolved.Mar 12 2026, 12:13 AM
Bhsd moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.
gerritbot added a comment.Mar 14 2026, 9:22 AM

Change #1251845 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirror: restore focus when deactivating

https://gerrit.wikimedia.org/r/1251845

gerritbot added a project: Patch-For-Review.Mar 14 2026, 9:22 AM
gerritbot added a comment.Mar 18 2026, 1:36 AM

Change #1251845 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: restore focus when deactivating

https://gerrit.wikimedia.org/r/1251845

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 18 2026, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2026, 2:33 AM
Jack_who_built_the_house mentioned this in rMGCDd6996507e3f0: don't focus comment input when deactivating CodeMirror.Mar 23 2026, 5:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits