Page MenuHomePhabricator

Add gender support to growthexperiments-exception-no-mentored-text
Closed, ResolvedPublicBUG REPORT

Description

The message growthexperiments-exception-no-mentored-text has no gender support. It is somewhat seen even in English, where the "they" pronoun is used; with gender support, it could also be "he" or "she". And in some other languages, it's needed even more.

Guidance:

  • Add $username argument to UserNotMentoredException.
  • Pass it to the parent's constructor (in an array as the third argument).
  • Update all usages to pass the username.
  • Change growthexperiments-exception-no-mentored-text in i18n/mentorship/en.json to something like User has no mentor, which means {{GENDER:$1|he|she|they}} cannot ask {{GENDER:$1|his|her|their}} mentor a question
  • Document the parameter in i18n/mentorship/qqq.json.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

I have submitted the patch for review to address the requested changes in the GrowthExperiments extension.

Gerrit Review Link:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1288892

Change #1288892 had a related patch set uploaded (by Aklapper; author: Gkm563):

[mediawiki/extensions/GrowthExperiments@master] Add gender support to no mentored exception message

https://gerrit.wikimedia.org/r/1288892

Change #1288892 abandoned by Gkm563:

[mediawiki/extensions/GrowthExperiments@master] Add gender support to no mentored exception message

Reason:

Superseded by updated change with corrected commit footer:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1289010

https://gerrit.wikimedia.org/r/1288892

Change #1289010 had a related patch set uploaded (by Aklapper; author: Gkm563):

[mediawiki/extensions/GrowthExperiments@master] Add gender support to no mentored exception message

https://gerrit.wikimedia.org/r/1289010

Change #1289010 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add gender support to no mentored exception message

https://gerrit.wikimedia.org/r/1289010

Gkm563 moved this task from Incoming to Completed on the RoadToWiki board.