When viewing images, the "share image" links are a subtle option.
When viewing videos, the last frame gets an overlay which may be covering important information (as in some interface screencasts: example). This is unnecessary and too agressive.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make the endcard dismissable with click and esc | mediawiki/extensions/TimedMediaHandler | master | +29 -1 |
Event Timeline
Comment Actions
On mobile it gets even worse: it's animated, and after a few seconds it covers Media viewer's own exit button
Comment Actions
I was just trying to pause a video and study the still image, but the overlay obscured the details I was interested in.
For me, just being able to close the share overlay would have been good enough.
Comment Actions
@Ponor one of your files is not attached publicly to the ticket, can you fix that ? It's a bug, you can find here how to fix it: https://www.mediawiki.org/wiki/Phabricator/Help#File_visibility
Comment Actions
The share button and the pop-up dialog when viewing images are as simple and out of the way like this:
I mean... The share and embed options are used, what, close to never?
Comment Actions
Change #1281433 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Make the endcard dismissable with click and esc
Comment Actions
Change #1281433 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Make the endcard dismissable with click and esc
Comment Actions
I've made it dismissable. Once we switch to the new videojs version somewhere later this year, I will have to do a lot of modifications, and i'll probably change the share flow to be even less intrusive.