Page MenuHomePhabricator

Whitespaces nullifies filter ability using accout names
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Navigate to Suggested Investigations and click the filter icon
  • Select the Account textbox, hit tab to add a space and then enter account name : "CheckUser"

What happens?:

  • See that no dropdown options are displayed

What should have happened instead?:

  • Drop down options should be displayed

Other information (browser name/version, screenshots, etc.):

Event Timeline

hector.arroyo changed the task status from Open to In Progress.Tue, Feb 3, 3:50 PM
hector.arroyo claimed this task.
hector.arroyo updated the task description. (Show Details)

Change #1236337 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] SuggestedInvestigations: Ignore leading whitespaces on username filter

https://gerrit.wikimedia.org/r/1236337

Change #1237159 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/core@master] ApiQueryAllUsers: Ignore leading whitespaces on username filter

https://gerrit.wikimedia.org/r/1237159

Change #1237159 merged by jenkins-bot:

[mediawiki/core@master] ApiQueryAllUsers: Ignore leading whitespaces on username filter

https://gerrit.wikimedia.org/r/1237159

Change #1236337 abandoned by Harroyo-wmf:

[mediawiki/extensions/CheckUser@master] SuggestedInvestigations: Ignore leading whitespaces on username filter

Reason:

Solved via a backend change instead: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1237159

https://gerrit.wikimedia.org/r/1236337

An initial fix in CheckUser (#1236337) to trim the leading whitespaces in the frontend has been discarded, and a wider fix to make user search requests to remove leading whitespaces in the backend has been merged to core instead (#1237159).

This can go to QA now.

Test status: QA PASS

  • with white spaces the entered keyword is able to return results from the scroll list