Page MenuHomePhabricator
Create Task
Maniphest T416316

IPReputation: Improve caching logic to handle backend downtime
Open, Needs TriagePublic
Actions

Description

Summary

We want Extension:IPReputation to be more resilient to backend downtime. We can do this by increasing the length of time that IP data is held in the cache, to allow for extended weekend downtime if necessary, and be able to return results while the backend is restored.

Acceptance criteria

  • IPReputation returns cached stale results for up to 72 hours, while still ensuring fresh data is returned if the backend is online

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 secondmediawiki/extensions/IPReputationwmf/1.46.0-wmf.14+1 -1
IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 secondmediawiki/extensions/IPReputationmaster+1 -1
IPReputationIPoidDataLookup: Allow returning stale values for 72 hoursmediawiki/extensions/IPReputationwmf/1.46.0-wmf.14+170 -30
IPReputationIPoidDataLookup: Allow returning stale values for 72 hoursmediawiki/extensions/IPReputationwmf/1.46.0-wmf.13+170 -30
IPReputationIPoidDataLookup: Allow returning stale values for 72 hoursmediawiki/extensions/IPReputationmaster+170 -30
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Tue, Feb 3, 10:38 AM
gerritbot added a comment.Tue, Feb 3, 10:47 AM

Change #1236253 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@master] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236253

gerritbot added a project: Patch-For-Review.Tue, Feb 3, 10:47 AM
gerritbot added a comment.Tue, Feb 3, 11:03 AM

Change #1236259 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@master] IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 second

https://gerrit.wikimedia.org/r/1236259

kostajh moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Tue, Feb 3, 12:55 PM
gerritbot added a comment.Tue, Feb 3, 2:45 PM

Change #1236253 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@master] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236253

gerritbot added a comment.Tue, Feb 3, 2:46 PM

Change #1236259 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@master] IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 second

https://gerrit.wikimedia.org/r/1236259

kostajh mentioned this in rEIPR58fec741d790: IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 second.Tue, Feb 3, 2:48 PM
kostajh mentioned this in rEIPR147146172e72: IPReputationIPoidDataLookup: Allow returning stale values for 72 hours.
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Tue, Feb 3, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Feb 3, 3:32 PM
kostajh moved this task from In progress to Needs QA on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Wed, Feb 4, 10:43 AM
gerritbot added a comment.Wed, Feb 4, 10:59 AM

Change #1236689 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236689

gerritbot added a project: Patch-For-Review.Wed, Feb 4, 10:59 AM

Change #1236690 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.13] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236690

gerritbot added a comment.Wed, Feb 4, 2:14 PM

Change #1236690 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.13] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236690

gerritbot added a comment.Wed, Feb 4, 2:14 PM

Change #1236689 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] IPReputationIPoidDataLookup: Allow returning stale values for 72 hours

https://gerrit.wikimedia.org/r/1236689

kostajh mentioned this in rEIPRcdf781452a59: IPReputationIPoidDataLookup: Allow returning stale values for 72 hours.Wed, Feb 4, 2:15 PM
kostajh mentioned this in rEIPRe9918567d7d3: IPReputationIPoidDataLookup: Allow returning stale values for 72 hours.
Stashbot mentioned this in T414080: x1 increase in writes results in a large increase of binlog files (over 2000).Wed, Feb 4, 2:16 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-04T14:16:13Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1236739|Fix audio transcodes]], [[gerrit:1236749|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236748|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236690|IPReputationIPoidDataLookup: Allow returning stale values for 72 hours (T416316)]], [[gerrit:1236689|IPReput

Stashbot added a comment.Wed, Feb 4, 2:18 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-04T14:18:26Z] <urbanecm@deploy2002> hartman, kharlan, urbanecm: Backport for [[gerrit:1236739|Fix audio transcodes]], [[gerrit:1236749|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236748|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236690|IPReputationIPoidDataLookup: Allow returning stale values for 72 hours (T416316)]], [[gerrit:1236689|IPRe

Stashbot added a comment.Wed, Feb 4, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2026-02-04T14:24:31Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1236739|Fix audio transcodes]], [[gerrit:1236749|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236748|DatabaseUserImpactStore: log attempts to save zero pageviews values (T414080)]], [[gerrit:1236690|IPReputationIPoidDataLookup: Allow returning stale values for 72 hours (T416316)]], [[gerrit:1236689|IPRepu

Maintenance_bot removed a project: Patch-For-Review.Wed, Feb 4, 2:30 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.13; 2026-01-27); removed MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Wed, Feb 4, 3:00 PM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)); removed Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)).Tue, Feb 10, 9:07 AM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Flower (Feb 9 - Feb 27)) board.Tue, Feb 10, 9:07 AM
gerritbot added a comment.Wed, Feb 11, 1:51 PM

Change #1238712 had a related patch set uploaded (by STran; author: Kosta Harlan):

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 second

https://gerrit.wikimedia.org/r/1238712

gerritbot added a project: Patch-For-Review.Wed, Feb 11, 1:51 PM
gerritbot added a comment.Wed, Feb 11, 1:54 PM

Change #1238712 abandoned by STran:

[mediawiki/extensions/IPReputation@wmf/1.46.0-wmf.14] IPReputationIPoidRequestTimeoutSeconds: Lower default timeout to 1 second

Reason:

bad rebase

https://gerrit.wikimedia.org/r/1238712

Maintenance_bot removed a project: Patch-For-Review.Wed, Feb 11, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits