Page MenuHomePhabricator

Add e2e smoke test for Wikibase GraphQL functionality
Closed, ResolvedPublic3 Estimated Story Points

Description

Now that webonyx/graphql-php is included in mediawiki/vendor we can test the Wikibase GraphQL functionality in the quibble-apitests-only-vendor-php83 CI job. This is particularly useful for search-related functionality that currently relies heavily on test doubles in the integration test.

Since we have an extensive integration test suite, it is probably sufficient to have one basic test for each of the top-level fields item, itemsById and searchItems:

  • for the item field, test that we can get the item's label and a statement incl the property label and item value label
  • for the itemsById field, test the same as the above, but for two items
  • for searchItems, test that an item can be found by a matching property value pair

Note that the feature flag will have to be enabled in Wikibase.ci.php.

Event Timeline

Change #1238687 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] GQL: Add e2e test boilerplate

https://gerrit.wikimedia.org/r/1238687

Change #1238687 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] GQL: Add e2e test boilerplate

https://gerrit.wikimedia.org/r/1238687

Change #1240284 had a related patch set uploaded (by Kim.pham; author: Kim.pham):

[mediawiki/extensions/Wikibase@master] GQL: e2e tests

https://gerrit.wikimedia.org/r/1240284

Change #1240284 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] GQL: e2e tests

https://gerrit.wikimedia.org/r/1240284

Change #1242214 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] GQL: Skip search test without OpenSearch

https://gerrit.wikimedia.org/r/1242214

Change #1242214 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] GQL: Skip search test without OpenSearch

https://gerrit.wikimedia.org/r/1242214

@Physikerwelt apologies. Math tests should be back to green