Page MenuHomePhabricator
Create Task
Maniphest T416429

Remove rcprop attribute on fetchRecentActivity function
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

When you load PersonalDashboard and open the console log, you will see the following warning:

Screenshot 2026-02-03 at 13.45.32.png (23×492 px, 7 KB)

This is because the unpatrolled attribute for the API parameter rcprop doesn't exist. We should remove it altogether because it is an unused attribute.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Added permissions check before attempting to filter by unpatrolledmediawiki/extensions/PersonalDashboardmaster+26 -19
fetchRecentActivity function followupmediawiki/extensions/PersonalDashboardmaster+533 -488
Move unpatrolled to the correct attribute on fetchRecentActivity function so we're correctly filtering out patrolled editsmediawiki/extensions/PersonalDashboardmaster+3 -2
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Updated mocks and bumped versionrepos/modtools/vitest-plugin!15kgraesslekgraessle/add-get-user-rightsmain
Add mocks for mwrepos/modtools/vitest-plugin!13jsnJsn.sherman/T416429main
Customize query in GitLab

Event Timeline

Scardenasmolinar created this task.Feb 4 2026, 12:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2026, 12:40 AM
Samwalton9-WMF triaged this task as Low priority.Feb 5 2026, 5:42 PM
Scardenasmolinar renamed this task from Change rcprop attribute on fetchRecentActivity function to Remove rcprop attribute on fetchRecentActivity function.Feb 5 2026, 6:15 PM
Scardenasmolinar updated the task description. (Show Details)
Scardenasmolinar set the point value for this task to 2.Feb 5 2026, 6:29 PM
Samwalton9-WMF moved this task from Backlog to MVP on the PersonalDashboard board.Feb 9 2026, 3:42 PM
Scardenasmolinar changed the point value for this task from 2 to 0.5.Feb 9 2026, 3:58 PM
Kgraessle claimed this task.Tue, Feb 17, 12:01 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Tue, Feb 17, 3:55 PM

Change #1239977 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Move unpatrolled to the correct attribute on fetchRecentActivity function so we're correctly filtering out patrolled edits

https://gerrit.wikimedia.org/r/1239977

gerritbot added a project: Patch-For-Review.Tue, Feb 17, 3:55 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Tue, Feb 17, 3:59 PM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Tue, Feb 17, 4:11 PM
gerritbot added a comment.Tue, Feb 17, 4:23 PM

Change #1239977 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Move unpatrolled to the correct attribute on fetchRecentActivity function so we're correctly filtering out patrolled edits

https://gerrit.wikimedia.org/r/1239977

Maintenance_bot removed a project: Patch-For-Review.Tue, Feb 17, 4:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.17; 2026-02-24).Tue, Feb 17, 5:00 PM
gerritbot added a comment.Tue, Feb 17, 7:05 PM

Change #1240019 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PersonalDashboard@master] fetchRecentActivity function followup

https://gerrit.wikimedia.org/r/1240019

gerritbot added a project: Patch-For-Review.Tue, Feb 17, 7:05 PM
Kgraessle moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Wed, Feb 18, 9:15 AM
CodeReviewBot added a comment.Wed, Feb 18, 12:36 PM

jsn opened https://gitlab.wikimedia.org/repos/modtools/vitest-plugin/-/merge_requests/13

Add mock for mw.util.getParamValue

jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Wed, Feb 18, 3:20 PM
CodeReviewBot added a comment.Wed, Feb 18, 3:57 PM

kgraessle merged https://gitlab.wikimedia.org/repos/modtools/vitest-plugin/-/merge_requests/13

Add mocks for mw

CodeReviewBot added a comment.Thu, Feb 19, 9:13 AM

kgraessle opened https://gitlab.wikimedia.org/repos/modtools/vitest-plugin/-/merge_requests/15

Refactor mocks and bumped version

gerritbot added a comment.Thu, Feb 19, 9:24 AM

Change #1240617 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Added permissions check before attempting to filter by unpatrolled

https://gerrit.wikimedia.org/r/1240617

gerritbot added a comment.Thu, Feb 19, 3:29 PM

Change #1240019 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] fetchRecentActivity function followup

https://gerrit.wikimedia.org/r/1240019

CodeReviewBot added a comment.Thu, Feb 19, 6:03 PM

kgraessle merged https://gitlab.wikimedia.org/repos/modtools/vitest-plugin/-/merge_requests/15

Updated mocks and bumped version

Kgraessle moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Thu, Feb 19, 6:06 PM
gerritbot added a comment.Thu, Feb 19, 8:45 PM

Change #1240617 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Added permissions check before attempting to filter by unpatrolled

https://gerrit.wikimedia.org/r/1240617

Scardenasmolinar moved this task from In Progress to QA on the Moderator-Tools-Team (Kanban) board.Thu, Feb 19, 9:10 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Feb 19, 9:31 PM
jsn.sherman closed this task as Resolved.Wed, Feb 25, 6:30 PM
jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.

verified on testwiki

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits