Hi team! I've had a go here with editing both templates in Civi. All work is currently in draft mode.

Copy Document
WMF Recurring failure message - English (United States)
WMF Recurring second failure message - English (United States)

@Lars when you have a moment, could you take a look for a "health check"? Particularly anything to do with CiviCRM variables/tokens. Greatly appreciated!

Additionally, a variable named {contribution_recur.next_sched_contribution_date} seems to be available in WMF Recurring second failure message but not in WMF Recurring failure message. Is it possible to add it in the first template as well?

cc: @NNgu-WMF

Change #1238837 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Add next sched contribution date to example data for failure email 1

https://gerrit.wikimedia.org/r/1238837

Thanks @ppenloglou

Nothing jumps out at me from those.

@Cstone was working on replacing the donate link with a token (so that if we want to change it in the future, we won't have to change translations and we won't risk those getting out of sync, which is the situation we are in now). I imagine that would be done next week, so can we wait for that before we go any further on this?

Beyond the donation url token, we've also talked about turning some of those other vars which are being assigned in smarty at the top of the email into tokens, for the same reason as above. The frequency one seems particularly ripe for replacement with a token, but we could do more than just that one. What are your thoughts on that approach?

Will add {contribution_recur.next_sched_contribution_date} to the sample data for the first failure message.

Change #1238837 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add next sched contribution date to example data for failure email 1

https://gerrit.wikimedia.org/r/1238837

Donate Link
Wondering what will be tokenized regarding the donate link? Different mailings may have other parameter values. Taking these two mailings as an example there's an extra _2 for wmf_source

WMF Recurring failure message
https://donate.wikimedia.org/?wmf_campaign=FailedRecur&wmf_medium=civi-mail&wmf_source=FY{$currentFiscalYear}_FailedRecur&contact_id={contact.id}&contact_hash={contact.hash}&appeal=SupportingWikipedia&uselang=en&monthlypitch=1&frequency={$txtMonthlyAnnual}

WMF Recurring second failure message
https://donate.wikimedia.org/?wmf_campaign=FailedRecur&wmf_medium=civi-mail&wmf_source=FY{$currentFiscalYear}_FailedRecur_2&contact_id={contact.id}&contact_hash={contact.hash}&appeal=SupportingWikipedia&uselang=en&monthlypitch=1&frequency={$txtMonthlyAnnual}

uselang also comes to mind as we hardcode it, given that we "know" which locale we're currently editing.

I guess

• Can the same token behave differently across different mailings?
• Can the same token behave differently across locales of the same mailing?

Smarty Assignments
Additionally, the custom assignments for dynamic copy isn't that much of a lift for us. For example, when checking:

'{contribution_recur.frequency_unit}'==='month'

one mailing may need the word monthly but others may need monthly,Monthly and month. We assign only the words we need in a mailing typically. And the above changes per locale!

If this were to become a token, could we leverage the following? (I don't know what it's called in Civi, I guess it's a modifier)

{contact.preferred_language:label} = English (United States)
{contact.preferred_language} = en_US

so in this frequency case:

{contribution_recur.frequency_unit} = month
{contribution_recur.frequency_unit:monthly} = monthly
{contribution_recur.frequency_unit:monthlyUpper} = Monthly

But that doesn't take into account annual frequency. I'll stop rambling now :D

Hi @ppenloglou and @Lars , is the above discussion a blocker for pushing the updated emails from draft to current? Wondering when I can send myself and Mariana. test email for QA.

Hey @NNgu-WMF , not a blocker! We’re discussing potential improvements to the Civi Mailing editor. I’m not entirely sure from your reply whether the templates need to be active for QA, so I’ll err on the side of caution and keep them as drafts. That said, they’re fully ready to if you want to switch them to Active by pressing Activate Draft

They look good! I just QA'ed them in Civi and Activated drafts for both. Will send test emails to myself and forward to Mariana for review :) Thank you all for your help!!

Could @AMJohnson and I get a test send too please? Thanks!

Yes @krobinson and @AMJohnson, you can test it through the UI by going to a recurring donation you have and clicking on Send 1st/2nd Failure Email. I'll also forward the tests I sent to myself if that's easier!

@NNgu-WMF @krobinson @AMJohnson is the English version done with testing?

@Cstone done with testing! Can we make sure that the gap between emails 1 and 2 is 7 days? Thank you!