Improve test coverage of SpecialMWOAuthConsumerRegistration
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• DAlangi_WMF
	Feb 4 2026, 3:00 PM

Project Tags

Referenced Files

	F77568576: image.png
	Apr 23 2026, 9:46 PM

	F77568533: image.png
	Apr 23 2026, 9:46 PM

	F77568524: image.png
	Apr 23 2026, 9:46 PM

	F77514166: image.png
	Apr 23 2026, 4:24 PM

	F77514133: image.png
	Apr 23 2026, 4:24 PM

	F77514099: image.png
	Apr 23 2026, 4:24 PM

	F72153376: Screenshot 2026-02-17 at 3.00.24 PM.png
	Feb 17 2026, 2:03 PM

	F72153374: Screenshot 2026-02-17 at 3.01.48 PM.png
	Feb 17 2026, 2:03 PM

Subscribers

Description

SpecialMWOAuthConsumerRegistration is the flow for registering and updating OAuth 1 and OAuth 2 consumers. It would most likely involve writing unit and integration tests to cover the functionality.

We'll likely write integration tests to cover functionality related to the Special page UI, the /propose and /update features, and their interactions with the action API and the DB (e.g., SubmitControl for the aforementioned endpoints). It's probably possible to use SpecialPageTestBase, since this will involve testing a special page and ApiTestCase for action API-related functionality.

Impact

Increase coverage of the respective special page: https://doc.wikimedia.org/cover-extensions/OAuth/src/Frontend/SpecialPages/SpecialMWOAuthConsumerRegistration.php.html
Increase coverage of submit control classes (T416761)
- https://doc.wikimedia.org/cover-extensions/OAuth/src/Control/ConsumerSubmitControl.php.html
- https://doc.wikimedia.org/cover-extensions/OAuth/src/Control/SubmitControl.php.html

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
tests: Allow SpecialMWOAuthConsumerRegistrationTest to cover ConsumerSubmitControl, SubmitControl	mediawiki/extensions/OAuth	master	+2 -0
tests: Fix SpecialMWOAuthConsumerRegistrationTest failure	mediawiki/extensions/OAuth	master	+1 -2
tests: Follow-up on Ied5d04ece0ececa14dfb5	mediawiki/extensions/OAuth	master	+7 -8
tests: Add integration tests for Special:MWOAuthConsumerRegistration	mediawiki/extensions/OAuth	master	+573 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T415281 [EPIC] OAuth extension critical workflows (for automated tests enhancement)
		Resolved		• DAlangi_WMF	T416490 Improve test coverage of SpecialMWOAuthConsumerRegistration

Event Timeline

• DAlangi_WMF created this task.Feb 4 2026, 3:00 PM

Reedy added a project: Test-Coverage.Feb 4 2026, 10:27 PM

Adding QS-Test-Automation to keep aware of this, this is a great effort. Where's test coverage going to be documented? Will it flow to https://doc.wikimedia.org/cover-extensions/ or somewhere else?

In T416490#11585616, @SLong-WMF wrote:

Adding QS-Test-Automation to keep aware of this, this is a great effort. Where's test coverage going to be documented? Will it flow to https://doc.wikimedia.org/cover-extensions/ or somewhere else?

Ack! It'll flow to the site you linked above. Specifically: https://doc.wikimedia.org/cover-extensions/OAuth/src/index.html

• DAlangi_WMF updated the task description. (Show Details)Feb 5 2026, 9:22 AM

• DAlangi_WMF moved this task from Essential Work to OKR Work on the MediaWiki-Platform-Team (Kanban Board) board.Feb 5 2026, 10:01 AM

OWresch-WMF moved this task from OKR Work to Next on the MediaWiki-Platform-Team (Kanban Board) board.Feb 5 2026, 10:05 AM

For /propose:

owner-only / non-owner-only workflow is very different
OAuth 1 and 2 are quite different
should test consumers using RSA keys vs. a secret
need separate tests for auto-approved ($wgOAuthAutoApprove) and non-auto-approved consumers
there are a bunch of error conditions that should have tests, like using http: for OAuth 2 (although maybe better handled in ConsumerSubmitControl unit tests)

For /update, I think the only meaningful difference is RSA keys vs. secrets (and even that only when the reset option is used).

Tgr mentioned this in T416557: Improve test coverage for OAuth2 authorization and token exchange.Feb 5 2026, 10:42 PM

• DAlangi_WMF updated the task description. (Show Details)Feb 7 2026, 6:07 AM

• DAlangi_WMF changed the task status from Open to In Progress.Feb 9 2026, 8:41 AM

• DAlangi_WMF claimed this task.

• DAlangi_WMF moved this task from Next to In Progress on the MediaWiki-Platform-Team (Kanban Board) board.

Change #1238314 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/OAuth@master] tests: Add integration tests for Special:MWOAuthConsumerRegistration

https://gerrit.wikimedia.org/r/1238314

gerritbot added a project: Patch-For-Review.Feb 10 2026, 11:52 AM

(17/02/2026): A measure of code coverage report generated locally for this class:

Screenshot 2026-02-17 at 3.01.48 PM.png (3,438×1,088 px, 458 KB)

Screenshot 2026-02-17 at 3.00.24 PM.png (1,917×644 px, 169 KB)

OWresch-WMF triaged this task as Medium priority.Feb 19 2026, 10:22 AM

Change #1244642 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/OAuth@master] tests: Follow-up on Ied5d04ece0ececa14dfb5

https://gerrit.wikimedia.org/r/1244642

SLong-WMF moved this task from Backlog to Tracking Only on the QS-Test-Automation board.Feb 26 2026, 11:21 PM

matmarex updated the task description. (Show Details)Apr 23 2026, 4:24 PM

Change #1238314 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Add integration tests for Special:MWOAuthConsumerRegistration

https://gerrit.wikimedia.org/r/1238314

Change #1244642 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Follow-up on Ied5d04ece0ececa14dfb5

https://gerrit.wikimedia.org/r/1244642

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 23 2026, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2026, 6:31 PM

Change #1276759 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OAuth@master] tests: Fix SpecialMWOAuthConsumerRegistrationTest failure

https://gerrit.wikimedia.org/r/1276759

gerritbot added a project: Patch-For-Review.Apr 23 2026, 7:17 PM

Change #1276787 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OAuth@master] tests: Allow SpecialMWOAuthConsumerRegistrationTest to cover ConsumerSubmitControl, SubmitControl

https://gerrit.wikimedia.org/r/1276787

Change #1276759 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Fix SpecialMWOAuthConsumerRegistrationTest failure

https://gerrit.wikimedia.org/r/1276759

Change #1276787 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Allow SpecialMWOAuthConsumerRegistrationTest to cover ConsumerSubmitControl, SubmitControl

https://gerrit.wikimedia.org/r/1276787

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2026, 9:31 PM

With these patches:

Increase coverage of the respective special page: https://doc.wikimedia.org/cover-extensions/OAuth/src/Frontend/SpecialPages/SpecialMWOAuthConsumerRegistration.php.html

https://doc.wikimedia.org/cover-extensions/OAuth/src/Control/ConsumerSubmitControl.php.html

https://doc.wikimedia.org/cover-extensions/OAuth/src/Control/SubmitControl.php.html

Perhaps we can consider this done?

@matmarex, yes, I think this one has been significantly covered. Maybe @JTweed-WMF could look at this and conclude, but my opinion would be closing it.

matmarex closed this task as Resolved.Apr 27 2026, 9:54 PM

Improve test coverage of SpecialMWOAuthConsumerRegistrationClosed, ResolvedPublicActions