| Esanders | |
| Wed, Feb 4, 6:39 PM |
| F71691219: image.png | |
| Thu, Feb 5, 1:13 PM |
| F71691186: image.png | |
| Thu, Feb 5, 1:13 PM |
| F71674635: image.png | |
| Wed, Feb 4, 6:45 PM |
| F71674556: image.png | |
| Wed, Feb 4, 6:39 PM |
| F71674518: image.png | |
| Wed, Feb 4, 6:39 PM |
Gerrit patches used to appear as comments, but now appear as "events" alongside other non-comment activity:
Usually gerrit activity is much more important than the task description being tweaked, and this is lost not in a sea of noise.
It would be nice if they were given more prominent styling, e.g.
I note in the html, these are differentiated with phui-timeline-major-event and phui-timeline-minor-event classes, however the styling is nearly identical.
As a starting point:
.phui-timeline-major-event a.phui-timeline-image[href="/p/gerritbot/"] ~ .phui-timeline-group .phui-timeline-core-content .transaction-comment { background: white; border-radius: 3px; padding: 2px 8px; border: 1px solid #d5d8e1; }
Yeah, this is my doing from T393289: Deploy user style to reduce bot comments on Phabricator.
It would be neat to have some styling that is more prominent than other timeline entries, but less prominent than human comments. I still think that it's more important to ensure that human activity is not lost in the sea of bot noise in cases like T415723#11560440 (with the default Phabricator styling, these comments would be all but impossible to notice).
I'll think about this when I find the time. Another idea would be to maybe make the timeline icon bigger?
It would be neat to have some styling that is more prominent than other timeline entries, but less prominent than human comments.
I think this proposal is still much less prominent that human comments:
and in the example you gave:
In this example it's a bit more cluttered but I don't think we should optimise for the edge case where dozens of patches are attached to one task, most only have 1 or 2.