Page MenuHomePhabricator

Append a tag to published edits in which someone acts on an Edit Suggestion
Open, HighPublic

Description

T413419 introduced an edit tag that is appended edits in which someone, theoretically, saw an Edit Suggestion within their browser's viewport.

This task involves the work of introducing edit tags that are applied to published edits in which someone acts on 1 or more Edit Suggestions within a given edit session.

The above, combined with the instrumentation already in place to know whether a suggestion was available within a given edit session, will equip us with the info. we need to understand the Suggestion funnel:
Suggestion available (implemented via VEFU)

editsuggestion-visible (T413419)

Suggestion action taken (implemented via VEFU)

Edit published (this ticket)

Story

  1. As someone seeking to understand the impact of surfacing suggestions within Suggestion Mode, I want published edits to be tagged when someone acts on one or more Edit Suggestions during an edit session, so that I can understand how the full Suggestion funnel is performing, from available → visible/seen → acted upon → published.
  2. As someone seeking to assess the quality of edits published by people who act on suggestions, I want to be able to identify and review specific edits in which a suggestion was acted upon, so that I can determine what, if any, adjustments are needed to ensure suggestions are leading contributors to publish constructive changes.

Requirements

Tag

  • An visible edit tag is applied to any published edit in which ≥1 Edit Suggestion action was taken during the edit session. This tag will be called editsuggestion-used
    • Where "action" here refers to the button associating with implementing, or beginning to implement a suggestion.
  • The tag is appended regardless of how many suggestions were acted upon within a given edit session
  • Tag ought to be applied across all platforms where Edit Suggestions are deployed (e.g., desktop and mobile VE)

Superset

NOTE: we recognize the above will amount to a relatively generic signal that will need to be combined with manually reviewing diffs in order to fulfill the second Story above. We are okay with this for the time being.

QA

To verify there are no false positives and negatives, please validate instrumentation against a sample of edit sessions to confirm:

  • No tags are being applied without someone taking action on a Suggestion
  • Tags are being applied whenever someone acts on a Suggestion, regardless of type and quantity

Done

  • Requirements are implemented
  • mw:Edit check/Tags is updated to include tag this ticket implements

Related