Page MenuHomePhabricator
Create Task
Maniphest T416537

Revise Tone: scrolling on mobile
Open, HighPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • On a mobile device
  • Open the Homepage (and ensure you are opted into the Revise Tone task)
  • Navigate to a Revise Tone task

What happens?:

  • Notice that you often don't automatically get scrolled down to have the edit check actually in view.

Example: https://share.cleanshot.com/9L1BklKJ

What should have happened instead?:

  • The Edit Check card should display by default AND the paragraph with the Edit Check present should be visible on screen.

Possibly related bug: T411367: Page scrolls to the very top on a small scroll up gesture

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests(ReviseTone): assert scrolling works on mobile and card stays visiblemediawiki/extensions/GrowthExperimentsmaster+19 -5
ReviseToneInitializer: select the action before ensuring it's shownmediawiki/extensions/GrowthExperimentsmaster+6 -1
Edit check controller: make sure ensure-shown action is scrolled into viewmediawiki/extensions/VisualEditormaster+34 -9
Update VE core submodule to master (b1b8c784c)mediawiki/extensions/VisualEditormaster+1 -1
ui.Surface: don't automatically scroll in adjustVisiblePaddingVisualEditor/VisualEditormaster+0 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.Wed, Feb 4, 11:14 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF triaged this task as High priority.Wed, Feb 4, 11:18 PM
KStoller-WMF moved this task from Inbox to Needs Prioritization on the Growth-Team board.
Etonkovidova added a comment.Thu, Feb 5, 12:59 AM

Testing enwiki wmf.13 - actually, I could not find any examples of correct scrolling on mobile. Even when a highlighted section is close to the top of an article page, the scrolling didn't happen. I checked with different mobile options - Advanced mode, Expand all sections and even parsoid version, all those do not have any effect on scrolling. Firefox displays the following message in the Console: This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.html for further details.

The desktop does provide correct scrolling for the cases when the highlighted section is close to the top of an article. In many other cases there is a quite confusing animation when a page loads, a warning popup appears, the quiz appears, then clicking on Help->Revise Tone will finally brings the highlighted section. The example below is for Nigel_Lockye, found with Physics filter (there are only 52 results, doesn't take long to find).

revise_tone animation.gif (887×1 px, 2 MB)

ppelberg subscribed.Thu, Feb 5, 4:36 PM
Michael added a project: Editing-team.Thu, Feb 5, 5:58 PM
DLynch subscribed.Thu, Feb 5, 8:35 PM

For testing purposes, which platform were you using? (iOS and Android have some fairly different behaviors here.)

gerritbot added a comment.Thu, Feb 5, 8:51 PM

Change #1237213 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] tests(ReviseTone): assert scrolling works on mobile and card stays visible

https://gerrit.wikimedia.org/r/1237213

gerritbot added a project: Patch-For-Review.Thu, Feb 5, 8:51 PM
gerritbot added a comment.Thu, Feb 5, 10:23 PM

Change #1237351 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] ui.Surface: don't automatically scroll in adjustVisiblePadding

https://gerrit.wikimedia.org/r/1237351

ppelberg edited projects, added Editing-team (Editing-2Feb-17Feb-2026); removed Editing-team.Fri, Feb 6, 7:27 AM
ppelberg moved this task from Decisions to be made to Doing on the Editing-team (Editing-2Feb-17Feb-2026) board.
ppelberg edited projects, added Editing-team (Editing-18Feb-27Feb-2026); removed Editing-team (Editing-2Feb-17Feb-2026).
ppelberg added a comment.Fri, Feb 6, 7:30 AM

At a minimum, the Editing Team will allocated a fixed amount of time to investigating the potential causes of this issue as part of #editing-16-27-feb.

The above, of course, assumes the patches @DLynch and @Michael wrote haven't already fixed this issue by then. [i][ii]

i. https://gerrit.wikimedia.org/r/1237213
ii. https://gerrit.wikimedia.org/r/1237351

gerritbot added a comment.Mon, Feb 9, 5:23 PM

Change #1237351 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ui.Surface: don't automatically scroll in adjustVisiblePadding

https://gerrit.wikimedia.org/r/1237351

gerritbot added a comment.Mon, Feb 9, 6:11 PM

Change #1237970 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b1b8c784c)

https://gerrit.wikimedia.org/r/1237970

gerritbot added a comment.Mon, Feb 9, 7:13 PM

Change #1237970 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b1b8c784c)

https://gerrit.wikimedia.org/r/1237970

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Mon, Feb 9, 8:00 PM
DMburugu moved this task from Needs Prioritization to Tracking on the Growth-Team board.Tue, Feb 10, 5:56 PM
gerritbot added a comment.Thu, Feb 12, 10:48 PM

Change #1239259 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check controller: make sure ensure-shown action is scrolled into view

https://gerrit.wikimedia.org/r/1239259

gerritbot added a comment.Fri, Feb 13, 1:28 AM

Change #1239273 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/GrowthExperiments@master] ReviseToneInitializer: select the action before ensuring it's shown

https://gerrit.wikimedia.org/r/1239273

gerritbot added a comment.Fri, Feb 13, 2:55 AM

Change #1239259 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check controller: make sure ensure-shown action is scrolled into view

https://gerrit.wikimedia.org/r/1239259

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.16; 2026-02-17); removed MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Fri, Feb 13, 3:00 AM
gerritbot added a comment.Fri, Feb 13, 2:52 PM

Change #1239273 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ReviseToneInitializer: select the action before ensuring it's shown

https://gerrit.wikimedia.org/r/1239273

DLynch claimed this task.Fri, Feb 13, 5:32 PM
DLynch edited projects, added Editing-team (Editing-2Feb-17Feb-2026); removed Editing-team (Editing-18Feb-27Feb-2026).
DLynch moved this task from Doing to Ready for Sign Off on the Editing-team (Editing-2Feb-17Feb-2026) board.
DLynch mentioned this in T411367: Page scrolls to the very top on a small scroll up gesture.Tue, Feb 17, 6:15 PM
ppelberg edited projects, added Editing-team (Editing-18Feb-27Feb-2026); removed Editing-team (Editing-2Feb-17Feb-2026).Tue, Feb 17, 11:11 PM
ppelberg moved this task from Decisions to be made to QA on the Editing-team (Editing-18Feb-27Feb-2026) board.
ppelberg added a project: Editing QA.Tue, Feb 17, 11:37 PM
ppelberg moved this task from Inbox to High Priority on the Editing QA board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits